From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9747F1F466 for ; Mon, 20 Jan 2020 18:54:07 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=U/KuBOsCUIrDgHw0 UrOg9zZ1lYt0UZ4DPBUNSpMLWchN0usEV1617faIqI9wyNrfIeHDHTolMTSOUrSh gtdrCcf437uLMU1zjM5CjlPoAkOeVxRKStCgY7G4FM9u6UAMIufhfb/pYA/O1NqQ vUdVkR/Ui0NufxCy1TeVw57oYaY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=lv0D3kJGOswuEaIanxJeiX 6RSqY=; b=jva0KMR2KhFTU6lLPVM5LGVPc09a2FSKJcX7FKg3OcG8g0dZeZuScW oQA6F2ZA0i1EsUADYGuAsqzgEUKhangptUsW3qLS8A3IuD99iH6vnyumncaaK+BN nEpUjm53STyitGLd2cLbMEerPu3OwDICtZ5f0zh4LJz/ydDi7ccyk= Received: (qmail 121678 invoked by alias); 20 Jan 2020 18:54:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 121667 invoked by uid 89); 20 Jan 2020 18:54:04 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RToDSmT4dYJJPIokEYVEj36kOwbaaaae7FkCxMKmrCE=; b=wa3FjZxxpNwvdVmD7Dn52zrCXvNJkLcEE9Eu5QM7c6RIRaO/YsW7L3GIUKG+koYXKE WZrxqkq74KW4d+LlIS4HyUEraRGFJNPk3onD39/c3YUnhEakRtrwXiEJtj/O3sNMrCYU 1l7hsAJp6eDEYczRXpK/8YC+8j1rhXcKFWKXqNfZhujzwdfZ4Ut6Loa6d5TDNSbP+fnU mKkTKHFjeL2Zv2yR1mqnWYoAVlNPH2g4lw5hBlqSrGoGx+2DOicRXa0H5KCWb5s03c6M mXthD9NNO59YPOQIpz/XDvhpYgKFug4VihaUJyomdrimuqLi6TpHY7L1e4sqZvjnBuBA 1JNw== Subject: Re: [PATCH 08/10] C11 threads: make thrd_join more portable To: libc-alpha@sourceware.org References: <20200114185255.25813-1-samuel.thibault@ens-lyon.org> <20200114185255.25813-10-samuel.thibault@ens-lyon.org> From: Adhemerval Zanella Message-ID: <94e8bd8c-2456-d267-ad20-9db8d634296c@linaro.org> Date: Mon, 20 Jan 2020 15:53:59 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200114185255.25813-10-samuel.thibault@ens-lyon.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 14/01/2020 15:52, Samuel Thibault wrote: > by making a __pthread_join call instead of an equivalent __pthread_clockjoin_ex > call. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > nptl/thrd_join.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/nptl/thrd_join.c b/nptl/thrd_join.c > index 783e36f02b..0c482959d5 100644 > --- a/nptl/thrd_join.c > +++ b/nptl/thrd_join.c > @@ -22,7 +22,7 @@ int > thrd_join (thrd_t thr, int *res) > { > void *pthread_res; > - int err_code = __pthread_clockjoin_ex (thr, &pthread_res, 0, NULL, true); > + int err_code = __pthread_join (thr, &pthread_res); > if (res) > *res = (int) (uintptr_t) pthread_res; > >