unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk \(man-pages\) via Libc-alpha" <libc-alpha@sourceware.org>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org,
	mtk.manpages@gmail.com
Subject: Re: [PATCH v5 27/35] init_module.2: Use syscall(SYS_...); for system calls without a wrapper
Date: Mon, 5 Apr 2021 13:41:29 +0200	[thread overview]
Message-ID: <93823d67-51a2-bf74-7a83-7a8b625b2da4@gmail.com> (raw)
In-Reply-To: <20210404115847.78166-28-alx.manpages@gmail.com>

Hi Alex,

On 4/4/21 1:58 PM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
>  man2/init_module.2 | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)


Patch applied.

Thanks,

Michael


> diff --git a/man2/init_module.2 b/man2/init_module.2
> index e158ce9fa..13d1b7f0a 100644
> --- a/man2/init_module.2
> +++ b/man2/init_module.2
> @@ -29,14 +29,15 @@
>  init_module, finit_module \- load a kernel module
>  .SH SYNOPSIS
>  .nf
> -.BI "int init_module(void *" module_image ", unsigned long " len ,
> -.BI "                const char *" param_values );
> -.BI "int finit_module(int " fd ", const char *" param_values ,
> -.BI "                 int " flags );
> -.fi
> +.BR "#include <linux/module.h>" "    /* Definition of " MODULE_* " constants */"
> +.BR "#include <sys/syscall.h>" "     /* Definition of " SYS_* " constants */"
> +.B #include <unistd.h>
>  .PP
> -.IR Note :
> -There are no glibc wrappers for these system calls; see NOTES.
> +.BI "int syscall(SYS_init_module, void *" module_image ", unsigned long " len ,
> +.BI "            const char *" param_values );
> +.BI "int syscall(SYS_finit_module, int " fd ", const char *" param_values ,
> +.BI "            int " flags );
> +.fi
>  .SH DESCRIPTION
>  .BR init_module ()
>  loads an ELF image into kernel space,
> @@ -268,11 +269,6 @@ manually declare the interface in your code;
>  alternatively, you can invoke the system call using
>  .BR syscall (2).
>  .PP
> -Glibc does not provide a wrapper for
> -.BR finit_module ();
> -call it using
> -.BR syscall (2).
> -.PP
>  Information about currently loaded modules can be found in
>  .IR /proc/modules
>  and in the file trees under the per-module subdirectories under
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  reply	other threads:[~2021-04-05 11:41 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-03 19:39 [PATCH v4 00/35] SYNOPSIS: Use syscall(SYS_...); and fix '#include's Alejandro Colomar via Libc-alpha
2021-04-03 19:39 ` [PATCH v4 01/35] system_data_types.7: Add 'struct sockaddr' Alejandro Colomar via Libc-alpha
2021-04-03 19:39 ` [PATCH v4 02/35] sockaddr.3: New link to system_data_types(7) Alejandro Colomar via Libc-alpha
2021-04-03 19:39 ` [PATCH v4 03/35] system_data_types.7: Add 'socklen_t' Alejandro Colomar via Libc-alpha
2021-04-03 19:39 ` [PATCH v4 04/35] socklen_t.3: New link to system_data_types(7) Alejandro Colomar via Libc-alpha
2021-04-03 19:39 ` [PATCH v4 05/35] access.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:39 ` [PATCH v4 06/35] add_key.2: Remove unused include Alejandro Colomar via Libc-alpha
2021-04-03 19:39 ` [PATCH v4 07/35] alloc_hugepages.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 08/35] arch_prctl.2: " Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 09/35] arch_prctl.2: SYNOPSIS: Remove unused includes Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 10/35] capget.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 11/35] clone.2: " Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 12/35] delete_module.2: Add missing include Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 13/35] dup.2: SYNOPSIS: Use consistent comments through pages Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 14/35] execveat.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 15/35] exit_group.2: Use 'noreturn' in prototypes Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 16/35] exit_group.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 17/35] fanotify_init.2: Add comment: why more than one include is needed Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 18/35] fcntl.2: Remove unused include Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 19/35] futex.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 20/35] futimesat.2: ffix Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 21/35] getdents.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 22/35] getpriority.2: Remove unused include Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 23/35] getrlimit.2, getrusage.2: " Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 24/35] getunwind.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 25/35] get_robust_list.2: " Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 26/35] delete_module.2: " Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 27/35] init_module.2: " Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 28/35] io_cancel.2: " Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 29/35] ioctl_fat.2: Make clear why is each header exactly needed Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 30/35] ioctl_fat.2: ffix Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 31/35] ioctl_ficlonerange.2: Make clear why is each header exactly needed Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 32/35] ioctl_fideduperange.2: Make clear why exactly is each header needed Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 33/35] ioctl_fslabel.2: ffix Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 34/35] ioctl_fslabel.2: Make clear why exactly is each header needed Alejandro Colomar via Libc-alpha
2021-04-03 19:40 ` [PATCH v4 35/35] ioctl_getfsmap.2: " Alejandro Colomar via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 00/35] SYNOPSIS: Use syscall(SYS_...); and fix '#include's Alejandro Colomar via Libc-alpha
2021-04-05 11:49   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-11 19:23     ` Alejandro Colomar (man-pages) via Libc-alpha
2021-04-11 19:30       ` Alejandro Colomar (man-pages) via Libc-alpha
2021-04-12  6:17     ` Florian Weimer via Libc-alpha
2021-04-12  6:39       ` Jakub Wilk
2021-04-12  9:09       ` Alejandro Colomar (man-pages) via Libc-alpha
2021-04-21  5:41         ` Florian Weimer via Libc-alpha
2021-04-24 15:46           ` Alejandro Colomar (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 01/35] system_data_types.7: Add 'struct sockaddr' Alejandro Colomar via Libc-alpha
2021-04-05 10:40   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 02/35] sockaddr.3: New link to system_data_types(7) Alejandro Colomar via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 03/35] system_data_types.7: Add 'socklen_t' Alejandro Colomar via Libc-alpha
2021-04-05 10:40   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 04/35] socklen_t.3: New link to system_data_types(7) Alejandro Colomar via Libc-alpha
2021-04-05 10:41   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 05/35] access.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-05 11:17   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 06/35] add_key.2: Remove unused include Alejandro Colomar via Libc-alpha
2021-04-05 10:51   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-05 10:55   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 07/35] alloc_hugepages.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-05 11:22   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 08/35] arch_prctl.2: " Alejandro Colomar via Libc-alpha
2021-04-05 11:25   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 09/35] arch_prctl.2: SYNOPSIS: Remove unused includes Alejandro Colomar via Libc-alpha
2021-04-05 11:26   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 10/35] capget.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-05 11:29   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 11/35] clone.2: " Alejandro Colomar via Libc-alpha
2021-04-05 11:31   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 12/35] delete_module.2: Add missing include Alejandro Colomar via Libc-alpha
2021-04-05 10:48   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 13/35] dup.2: SYNOPSIS: Use consistent comments through pages Alejandro Colomar via Libc-alpha
2021-04-05 11:32   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 14/35] execveat.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-05 11:33   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 15/35] exit_group.2: Use 'noreturn' in prototypes Alejandro Colomar via Libc-alpha
2021-04-05 10:43   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 16/35] exit_group.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-05 11:36   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 17/35] fanotify_init.2: Add comment: why more than one include is needed Alejandro Colomar via Libc-alpha
2021-04-05 10:50   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 18/35] fcntl.2: Remove unused include Alejandro Colomar via Libc-alpha
2021-04-05 10:44   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 19/35] futex.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 20/35] futimesat.2: ffix Alejandro Colomar via Libc-alpha
2021-04-05 10:42   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 21/35] getdents.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-05 11:37   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 22/35] getpriority.2: Remove unused include Alejandro Colomar via Libc-alpha
2021-04-05 10:49   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 23/35] getrlimit.2, getrusage.2: " Alejandro Colomar via Libc-alpha
2021-04-05 10:48   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 24/35] getunwind.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar via Libc-alpha
2021-04-05 11:37   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 25/35] get_robust_list.2: " Alejandro Colomar via Libc-alpha
2021-04-05 11:39   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 26/35] delete_module.2: " Alejandro Colomar via Libc-alpha
2021-04-05 11:41   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 27/35] init_module.2: " Alejandro Colomar via Libc-alpha
2021-04-05 11:41   ` Michael Kerrisk (man-pages) via Libc-alpha [this message]
2021-04-04 11:58 ` [PATCH v5 28/35] io_cancel.2: " Alejandro Colomar via Libc-alpha
2021-04-05 11:43   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 29/35] ioctl_fat.2: Make clear why is each header exactly needed Alejandro Colomar via Libc-alpha
2021-04-05 11:02   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 30/35] ioctl_fat.2: ffix Alejandro Colomar via Libc-alpha
2021-04-05 11:03   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 31/35] ioctl_ficlonerange.2: Make clear why is each header exactly needed Alejandro Colomar via Libc-alpha
2021-04-05 11:13   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 32/35] ioctl_fideduperange.2: Make clear why exactly is each header needed Alejandro Colomar via Libc-alpha
2021-04-05 11:16   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 33/35] ioctl_fslabel.2: ffix Alejandro Colomar via Libc-alpha
2021-04-05 11:10   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 34/35] ioctl_fslabel.2: Make clear why exactly is each header needed Alejandro Colomar via Libc-alpha
2021-04-05 11:04   ` Michael Kerrisk (man-pages) via Libc-alpha
2021-04-04 11:58 ` [PATCH v5 35/35] ioctl_getfsmap.2: " Alejandro Colomar via Libc-alpha
2021-04-05 11:10   ` Michael Kerrisk (man-pages) via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93823d67-51a2-bf74-7a83-7a8b625b2da4@gmail.com \
    --to=libc-alpha@sourceware.org \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).