From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 489201F46C for ; Mon, 13 Jan 2020 10:09:10 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:date:mime-version :in-reply-to:content-type:content-transfer-encoding:message-id; q=dns; s=default; b=YbxJXH8Xrmu5QcaH9qetMzcb2PtTw4DbtuoarWZdIq3 SLOFeaY/J17irzXlK+mmpNe3feJUmqHIhlIajI0u//ibm/N56G+lVojQOGRFjU1B jLRBtdtI9MzDFP4b6nsytzyyHPgReIt8sSWrF7ehuML0u0e+AJr1coOjmogB2T6c = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:date:mime-version :in-reply-to:content-type:content-transfer-encoding:message-id; s=default; bh=M3P5XybmHvE9+sGdCXwtVXuzdWg=; b=ab7NPxTgefxhja/Iu XLohVZbHfdTEhP+DVmCObunvc7QbfhInNF6D/kFsiWk5uDrRPpcrQGpnl9EZfA2O 9j2R++j2nNnkNhY6+YZHtu6OccOuCT046HKGOtvy1mDerT1NDL4KIaZudsF9r8VA cVO09Ywppx98ADNGFOZEsXAK7c= Received: (qmail 90358 invoked by alias); 13 Jan 2020 10:09:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 90349 invoked by uid 89); 13 Jan 2020 10:09:07 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <20191205172608.GA57577@aloka.lostca.se> <20191216143424.22882-1-ahajkova@redhat.com> <20200106180509.GA71028@aloka.lostca.se> <56533d16-d7d1-4e79-5a8f-ed4accb17247@gotplt.org> <357df77f-f709-8b35-b28d-e64f4524f92a@linux.ibm.com> <4e54f470-f07d-558a-b52e-031fb5df1a9d@gotplt.org> From: Stefan Liebler Date: Mon, 13 Jan 2020 11:08:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <4e54f470-f07d-558a-b52e-031fb5df1a9d@gotplt.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 20011310-0016-0000-0000-000002DCDB64 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20011310-0017-0000-0000-0000333F64BC Message-Id: <9300b2f4-e20a-71ae-ba93-629ec3774f17@linux.ibm.com> On 1/10/20 5:00 PM, Siddhesh Poyarekar wrote: > On 10/01/20 8:15 pm, Stefan Liebler wrote: >> Hi, >> >> If run on 32bit, this test fails while renaming tst-ldconfig-ld-mod.so >> as there is no /usr/lib64 directory. >> >> The attached patch is constructing the file name with help of >> support_libdir_prefix. >> >> If the patch is okay, let me know if I can commit it on master. > > Nice catch, looks OK to me. > > Reviewed-by: Siddhesh Poyarekar > Committed. Thanks, Stefan