From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9311E1F85E for ; Fri, 13 Jul 2018 15:49:30 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=p/I69fSVeCmxtB2c hIGTBEzu/n67+7dRKGxozvx15rwloV5xacaM5VphsC28nJrrY6vHK46TVn9MJcil rJIKPPgnZGoEkn/F6/2Vb/CqGx3fIa5xuZHYjyk0JlWKvdx34AHxSAi/Kq5H8AME eKBQ/pxNljB1kXiO0W/18VMzBZQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=glik0IhJMGWi/jRF2Dxjcj u0nEs=; b=rHNrJQ8I439X47HGRPwHfxMhYS7Ae/3/4hEL+i37b3gIA/6U83PKVb j6djrO1HFrPmwEs/G0s5l7KwAFSt2CeD2H6fF3zj2P0id+VwbaSvQl5x1gxhySKj zPRi1uv5HpVevXtnpK6G53//WQSXnV1uOGgs7uUTBeY88t9ny17BY= Received: (qmail 59779 invoked by alias); 13 Jul 2018 15:49:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 29896 invoked by uid 89); 13 Jul 2018 15:49:19 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-vk0-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=50Vz8DnqRLY+QVUAJ169r0o1vdWPYFj7G9RRSStI33s=; b=VFzMnicgQjMVjH0IE8OdmVcM8Nh1EaAeygl2SD/+/Xdn+0TkXPkkAA8+tEIC7wOVcv HwBWgXthI1gxslr5JqfXTgfVQ/YYK9eQRvbfG1uWRGuzgb9tjz5tAFhSovKy6NKR/j9/ /cl/jeAkjGwtlDfsmH+a2pvgT6TuGRguW2GoI= Subject: Re: [PATCH v8 6/8] nptl: Add abilist symbols for C11 threads To: Florian Weimer , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-7-git-send-email-adhemerval.zanella@linaro.org> <97b42cb3-e76a-ac71-65cd-c1f6d8c404aa@redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <90dc04ab-81df-b0d7-a086-d00ea5cc979d@linaro.org> Date: Fri, 13 Jul 2018 12:49:11 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <97b42cb3-e76a-ac71-65cd-c1f6d8c404aa@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 13/07/2018 06:50, Florian Weimer wrote: > On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >> This patch adds the required abilist symbols for C11 thread support. > > I manually compared the definitions in the header with the C11 standard.  The ABI looks good, with the exception of the once_flag definition and the possible change of the error encoding. > > Thanks, > Florian Thanks for all the reviews, I have updated my personal branch [1] with all you required changes: - ABI fixes for mips-gnu-linux-soft. - pthread_create / pthread_join cast inconsistency. - sysdeps/nptl/threads.h moved to nptl/threads.h. - thrd_sleep is now a cancellable entrypoint. - once_flag and ONCE_FLAG_INIT and __ONCE_ALIGNMENT definition. - thread_local guards for C++. - TSS_DTOR_ITERATIONS assert check. I am not sure about the thread error code mapping to errno, it will required tying POSIX error code to C11 use some internal mechanism It will most like require generate a platform-specific file auto-generated from errno definitions (more build complexity), and I am not sure if this micro-optimization will really yields any measurable gain. If you prefer I can resend the patches on maillist with a different version tag (I did not sent to avoid clobber the mailist). [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/c11-threads