From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7A09A1F461 for ; Thu, 16 May 2019 19:09:32 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=xZpigzLrLXwPXP3K KpN2EsuqfWD9sznwLkZ8YX8lnYY84EYykGx8lQbA7jfl4xuepAENO/sqpTMPp0j2 tXjxEOYe/XRoIdjPNViNhGhkDGC5MbgD85H0+EGV0G1ga+ZjMoQAwxHIW/ByGK2O CNS0kh9E2Lo+fnhc6fqNLlTOuAk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=N2BKLL+fBmVR4P1m8SjCkp Mvck0=; b=THX700QMNryfEyZE166V/b7UFXk5N/aON5BZm7BZ9wAJQKAwL+oQj7 IGPR4rixVQZfCO6hGqhcjDKVUCpEsmgE8M332b18Gh9PG+Bcjud2D7YiGBKs2+nD 4/4YRKQ5hY+fPe9gm0ifM8nWHvDKqnVV1w3whRsEPVtB0hkCENNB4= Received: (qmail 52046 invoked by alias); 16 May 2019 19:09:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 52038 invoked by uid 89); 16 May 2019 19:09:30 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-ua1-f65.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MoZaH+aQR3VKUrPgLtiS7aFu8dr0VAV3wXnSwSY3GcA=; b=MAEP8io9Lc+ckyw+6tsATDbo6lTQGETRCkqCtf6PHVHLKTky491NV7JcpQ0VaedDY+ yAFbdklPDTmB5N1WYcSy2q7L575mY3d1APc/vFdo3ZtEaf5Hu7ZP59mvK6a4jvsSrQPL tzNJam4SM3kst2Uco6cccXh98REXB9TywSLfjV/yaKOTVy8K6VraD1lX6doIa/X96xKX be5+MmQlr8mpMDJf2orGLjmtK7BTFMhmPc3BTA0BVS9L2758OVWduE9Xfwl2+HgKJLcO Ou3IMyBpAWw1OrTeedTY1GsV4NW86iJD9xy922EwRYgANlq6Hi8R8wU4OGolbCSdtwdg gz/g== Subject: Re: [PATCH 3/5] sysvipc: Consolidate semtimedop s390 To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20190516151249.19029-1-adhemerval.zanella@linaro.org> <20190516151249.19029-3-adhemerval.zanella@linaro.org> <87mujms8ye.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <907d21c0-fda8-ae6e-b9e7-f5fbc5deffbe@linaro.org> Date: Thu, 16 May 2019 16:09:24 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87mujms8ye.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 16/05/2019 12:41, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/sysdeps/unix/sysv/linux/ipc_priv.h b/sysdeps/unix/sysv/linux/ipc_priv.h >> index 65adbb093e..49018c1b28 100644 >> --- a/sysdeps/unix/sysv/linux/ipc_priv.h >> +++ b/sysdeps/unix/sysv/linux/ipc_priv.h >> @@ -34,4 +34,7 @@ struct __old_ipc_perm >> #define MSGRCV_ARGS(__msgp, __msgtyp) \ >> ((long int []){ (long int) __msgp, __msgtyp }) >> >> +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \ >> + (__nsops), 0, (__sops), (__timeout) > > Maybe add a reference to the s390 version? What about: /* This macro is required to handle the s390 variants, which passes the arguments in a different order than default. */ > >> diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/ipc_priv.h b/sysdeps/unix/sysv/linux/s390/s390-32/ipc_priv.h >> new file mode 100644 >> index 0000000000..9d74e92289 > >> +/* The s390 sys_ipc variant has only five parameters instead of six >> + (as for default variant) and the only difference is the handling of >> + SEMTIMEDOP where on s390 the third parameter is used as a pointer >> + to a struct timespec where the generic variant uses fifth parameter. */ >> +#undef SEMTIMEDOP_IPC_ARGS >> +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \ >> + (__nsops), (__timeout), (__sops) > > I find “and the only difference is” a bit confusing here. Maybe write > “. The difference is” instead? Ack, I change it locally. > > Rest of the patch looks okay to me. > > Thanks, > Florian >