From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1B75F20248 for ; Thu, 28 Feb 2019 04:52:57 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=Blaf2F+pUUHeuYZ8 MvkgYx7Fw7rrw8C3gBkXKHYt1HJR84AfM3u/3hct2+B8Hvye4N11rg1XmiN1wT50 boKLdN6F9sLqju8l+g7XKx/MV/zdbSya1MjihNeDYaqIWCnVH1iJ5IVu65l/MPsi Mc3ciomIL3bnWyK3it/MTf6lvgY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=R1UOm3qYcKOcNEpW2n/252 MG+oE=; b=K+wzmWafzzibJJCTNHPxil0TiIgZkiNn/yqRUBAe088T97xf4ASMmV 5umXl3lIImm778slpTxx3AJvTtPrmzGItlwhqwRxaDnxkGRlM77ijufZycMQjRPE dFBmuyltKXx9Ye5GgSplOui+GmacEtGsfTTrnkTad6yFuPwoY2eIE= Received: (qmail 121831 invoked by alias); 28 Feb 2019 04:52:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 119782 invoked by uid 89); 28 Feb 2019 04:52:53 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qt1-f194.google.com Subject: Re: [PATCH] Add malloc micro benchmark To: Wilco Dijkstra , 'GNU C Library' Cc: nd , Florian Weimer References: From: Carlos O'Donell Openpgp: preference=signencrypt Message-ID: <8ef46134-94fa-ffba-8f98-13a10a956e7b@redhat.com> Date: Wed, 27 Feb 2019 23:52:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2/1/19 11:27 AM, Wilco Dijkstra wrote: > Add a malloc micro benchmark to enable accurate testing of the > various paths in malloc and free. The benchmark does a varying > number of allocations of a given block size, then frees them again. > > It tests 3 different scenarios: single-threaded using main arena, > multi-threaded using thread-arena, main arena with SINGLE_THREAD_P > false. > > OK for commit? > > ChangeLog: > 2019-02-01 Wilco Dijkstra > > * benchtests/Makefile: Add malloc-simple benchmark. > * benchtests/bench-malloc-simple.c: New benchmark. This broke Fedora Rawhide during CI testing: BUILDSTDERR: bench-malloc-simple.c: In function 'bench': BUILDSTDERR: bench-malloc-simple.c:89:17: error: variable 'res' set but not used [-Werror=unused-but-set-variable] BUILDSTDERR: 89 | unsigned long res; BUILDSTDERR: | ^~~ BUILDSTDERR: cc1: all warnings being treated as errors Affects aarch64, armv7hl, and s390x. I assume we need a "(void) res" like we have in bench-malloc-thread.c? I'm going to checkin a quick fix to Rawhide and report back if anything else breaks. -- Cheers, Carlos.