From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2E48E1F406 for ; Wed, 13 Dec 2023 23:48:12 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=njQ4WbTI; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 73132385C6DD for ; Wed, 13 Dec 2023 23:48:11 +0000 (GMT) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id A41A83858D20 for ; Wed, 13 Dec 2023 23:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A41A83858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A41A83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702511281; cv=none; b=d/MYdqyH8PjqKWuZnJ9+cGo6Y8kUND0Vnqji0QUmQFvDDitN8ccNE5lK+TC3UegIV9P9oonO3Kxo4p7dyCsELWZG5kFgUPDa/ZXVNdA3tKwYOhpFfdLsL+FtF5Amk3n2jrHhBQF4aNZmm5xLKy5HnxYPY/5HgIwTTImmr48lNBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702511281; c=relaxed/simple; bh=rzdcKSqsSo2l5If8X85DavQAEMONGoFRrlWnobGmFWY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vVOx5Yj9mNouXQvmo3LYn3lKOnwoRtsqi7PXEBchhNYoUwt0coVi2N1L0cw91LsV7RfldABu0dB5pLn26s2HckbP2tjjbpekxYVgLquE5uj/LTBvQpgoye3+NlyPvAYNG6kLowD+/ThMEef6wFPuTpPZLmcASxy6uRUDICKRVX0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BDNlPAE015254 for ; Wed, 13 Dec 2023 23:48:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=GD0hU9pWq95Ph0uN6m8JvVcgI6ZuZNF4biUuzLKMyFE=; b=njQ4WbTIgA2W5XnKlXrgQqnCo/+MoiM3/91r7yyCCEJtQJKFYFYAzj5pUMA64vKrq2D+ qnt+mmb5D0IhWv4FSJE+wH0i80qXQELZzdAxNLXp0BaUoWrOp7t67qXx7ORdq+cH2imh xUJtMl62m7HD+iEM3q+1GezZC0gXtbjC//NVTqpfSZekTmSnMcslSB2VSYUQidPFGFri bE6ZfCrhIJH5bRO63ouQCke2hdtwoKmGTh8WMlqnha35JaMAXXwpJrErJjuM8qJ2GjwV NuPNGkRaxtyYvOtr/0dXTv5mVIUbM+BDXE3yzNacMjWvLFnyBohzxUroQ17S+S05R4sA gw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uym1sbu5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 13 Dec 2023 23:48:00 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BDNeMio027622 for ; Wed, 13 Dec 2023 23:47:59 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uym1sbu5c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:47:59 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BDNaofc014799; Wed, 13 Dec 2023 23:47:59 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uw42kg29y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:47:59 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BDNlwFR50135394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Dec 2023 23:47:58 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1E8A05805A; Wed, 13 Dec 2023 23:47:58 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1B7558051; Wed, 13 Dec 2023 23:47:57 +0000 (GMT) Received: from [9.61.181.199] (unknown [9.61.181.199]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 13 Dec 2023 23:47:57 +0000 (GMT) Message-ID: <8c5c3b9d-30d5-47b6-8da2-3aca0d9a5d22@linux.ibm.com> Date: Wed, 13 Dec 2023 17:47:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] powerpc: Add HWCAP3/HWCAP4 data to TCB for Power Architecture. Content-Language: en-US To: Manjunath Matti , libc-alpha@sourceware.org Cc: fweimer@redhat.com References: <20231205123848.2505641-1-mmatti@linux.ibm.com> <20231205123848.2505641-2-mmatti@linux.ibm.com> From: Peter Bergner In-Reply-To: <20231205123848.2505641-2-mmatti@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: iKqi48iqmTBFQSKIb2pTSCDMEcGZIiPS X-Proofpoint-GUID: u7h6wUhCtLPw3Myrsnr-b-Em6Cxs22DD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-13_14,2023-12-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312130168 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On 12/5/23 6:38 AM, Manjunath Matti wrote: > This patch adds a new feature for powerpc. In order to get faster > access to the HWCAP3/HWCAP4 masks, similar to HWCAP/HWCAP2 (i.e. for > implementing __builtin_cpu_supports() in GCC) without the overhead of > reading them from the auxiliary vector, we now reserve space for them > in the TCB. > > This is an ABI change for GLIBC 2.39. > > Suggested-by: Peter Bergner > --- > elf/dl-diagnostics.c | 2 + > elf/dl-support.c | 2 + > elf/elf.h | 4 ++ > sysdeps/generic/ldsodefs.h | 2 + > sysdeps/powerpc/dl-procinfo.c | 6 ++- > sysdeps/powerpc/dl-procinfo.h | 52 +++++++++++++------ > sysdeps/powerpc/hwcapinfo.c | 11 ++-- > sysdeps/unix/sysv/linux/dl-parse_auxv.h | 2 + > sysdeps/unix/sysv/linux/dl-sysdep.c | 2 + > .../unix/sysv/linux/powerpc/cpu-features.c | 2 + > .../unix/sysv/linux/powerpc/cpu-features.h | 2 + > sysdeps/unix/sysv/linux/powerpc/libc-start.c | 6 +++ > 12 files changed, 74 insertions(+), 19 deletions(-) LGTM. The only catch is that this patch is dependent on the associated kernel patch that adds the AT_HWCAP3 and AT_HWCAP4 getting upstream so glibc can rely on their values. I'm still working on upstreaming that. Reviewed-by: Peter Bergner Peter