From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Adhemerval Zanella Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: [PATCH v2 21/21] nptl: riscv: Fix Race conditions in pthread cancellation (BZ#12683) Date: Tue, 27 Feb 2018 10:03:07 -0300 Message-ID: <8acd994f-eda7-ef5c-579c-ddaa88e205b1@linaro.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1519736478 27262 195.159.176.226 (27 Feb 2018 13:01:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Feb 2018 13:01:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: libc-alpha@sourceware.org To: DJ Delorie Original-X-From: libc-alpha-return-90658-glibc-alpha=m.gmane.org@sourceware.org Tue Feb 27 14:01:14 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=PXODafNm/OeipMx4 G47mqcBemLzpLPd6sIIgokIgLZUsB5BXB2VVNVD4nN4ZkP8M5rwAVQqmFV//D1nQ yr+iVvZw7H8xtsvjcczrcIWgNS+U9mO/HslIqVK6PQ2hJXF/53WoSk4PW60hZ1Ra rg0FJVaSDYYgwBKwjGISQC0CvbU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=7KwKFFIMw8kIIXXDAYo4yz 5A9mg=; b=NVTD1FsCfFyH1uf1RT0jEsWG57YvTN2NUJvRt2aQTOoOguZcOD2Pfw 8cvUilR3BIiUnpHOSS4DFL8k2sxRq3+syyeYQztjgH+m8Jq36NgJ0+Ags8+sNdCv 36KakSsGQuqUQpwiQAIhzMcVf3joNWww0anekIYfHfmef7gAbQOac= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f194.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ci1T+LhOXVH/AzyO5TSuJT+uIHqWKXSx1I+X08PeZyM=; b=QrH9s7n0mRWdw12QXEHXyIrpwT+F9uSu1YFXZB/2nxowa6nQVw4YJianAN8grsWBfF jCrJ5uardJToD2XE6NUEgZiyqtUBg8KZnAMB1xX5F5oQ4JtJhr3GONOk74pcjvXSpqdL PRnjV85czE6Q0n8aUyjB3BKkyhLARRlo171pyv62udHn186F09jhYyYgZUxgG8lzbdel bknygq6Jny4z0nnaJbaAuEjtqsGFIGECsSOHOQ74KeuG96G8BSI6/NuWTS6NCVG8FE75 ovJwWrackgKlZKBTEKprMf7JOQMuMvboDqSEnzLbfpc75rubG06PWTHYsZbVP+xHLZ+F QHqg== X-Gm-Message-State: APf1xPCE9E9Bp1fNhgYUddXFz0oLdfgyFlwvd6xqYWAQjPbykHZy+N+w SMZHivyD0QHUrZOHNjhpaSY5pppVhio= X-Google-Smtp-Source: AG47ELtjpVKHPOh55VRvynWtw3CEnpWA1P9SpXt+dv5bd6zz0GRA0hojoC/AU8J+yvvj1FMYL5wcxQ== X-Received: by 10.200.16.142 with SMTP id a14mr12318536qtj.65.1519736592764; Tue, 27 Feb 2018 05:03:12 -0800 (PST) In-Reply-To: Xref: news.gmane.org gmane.comp.lib.glibc.alpha:82989 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqesc-0006XJ-4H for glibc-alpha@blaine.gmane.org; Tue, 27 Feb 2018 14:01:14 +0100 Received: (qmail 58781 invoked by alias); 27 Feb 2018 13:03:17 -0000 Received: (qmail 58766 invoked by uid 89); 27 Feb 2018 13:03:16 -0000 On 26/02/2018 22:16, DJ Delorie wrote: > Adhemerval Zanella writes: >> +static inline uintptr_t >> +ucontext_get_pc (const ucontext_t *uc) >> +{ >> + return uc->uc_mcontext.__gregs[REG_PC]; >> +} > > That file already has a GET_PC() macro; why not use it? > (I mean, in the definition of this function) > I used just to avoid the extra cast (long int -> void -> uintptr_t). I do not have a strong preference here in fact.