From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, PDS_RDNS_DYNAMIC_FP,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E49821F8C6 for ; Fri, 9 Jul 2021 09:18:26 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F345F3983827 for ; Fri, 9 Jul 2021 09:18:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F345F3983827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625822306; bh=CP2RLgqUYSOMPOjQj3gZMcWlH6UOiFd9ZOSoKdXQVLc=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RdLPtVCXUgdzC3LqyO6t7PSn4DopO/72VTkXRC3PGVhqBiz7XTV5GcNuJkcbd46Qb 3XRn93C5spo0u5xdfHN7W2cYdiYBJlgsQLAvNPPWimd7FYWAaxV/fHoZcpDX1GKv9V LiidR9B6OapTbzTIuGGBZ1qL/25c67p3bWAtKBQo= Received: from black.elm.relay.mailchannels.net (black.elm.relay.mailchannels.net [23.83.212.19]) by sourceware.org (Postfix) with ESMTPS id 16F7B38515FF for ; Fri, 9 Jul 2021 09:18:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16F7B38515FF X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CC16034263C; Fri, 9 Jul 2021 09:18:03 +0000 (UTC) Received: from pdx1-sub0-mail-a31.g.dreamhost.com (100-96-18-103.trex.outbound.svc.cluster.local [100.96.18.103]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 182B7342C9F; Fri, 9 Jul 2021 09:18:03 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a31.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.18.103 (trex/6.3.3); Fri, 09 Jul 2021 09:18:03 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Bottle-Attack: 67bd9db65be44ad1_1625822283313_2611961517 X-MC-Loop-Signature: 1625822283313:834520507 X-MC-Ingress-Time: 1625822283313 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id D3E39852E0; Fri, 9 Jul 2021 02:18:02 -0700 (PDT) Received: from [192.168.1.137] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id 0D15E8080F; Fri, 9 Jul 2021 02:18:00 -0700 (PDT) Subject: Re: [PATCH v7 3/8] Move malloc hooks into a compat DSO To: Florian Weimer References: <20210708174325.3243721-1-siddhesh@sourceware.org> <20210708174325.3243721-4-siddhesh@sourceware.org> <878s2fkij8.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a31 Message-ID: <8a3d2b7c-c22a-7026-5650-b24aac304e43@sourceware.org> Date: Fri, 9 Jul 2021 14:47:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <878s2fkij8.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Siddhesh Poyarekar via Libc-alpha Reply-To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/9/21 1:47 PM, Florian Weimer via Libc-alpha wrote: > This has another issue on i686-gnu. This looks like the locking code > does not work outside of libc: > > /home/bmg/install/compilers/i686-gnu/lib/gcc/i686-glibc-gnu/11.1.1/../../../../i686-glibc-gnu/bin/ld: /home/bmg/build/glibcs/i686-gnu/glibc/malloc/libc_malloc_debug_pic.a(malloc-debug.os): in function `__malloc_info': > /home/bmg/src/glibc/malloc/malloc.c:5670: undefined reference to `__gsync_wait' > /home/bmg/install/compilers/i686-gnu/lib/gcc/i686-glibc-gnu/11.1.1/../../../../i686-glibc-gnu/bin/ld: /home/bmg/src/glibc/malloc/malloc.c:5756: undefined reference to `__gsync_wake' > > I'm not entirely sure how this is supposed to work. Clearly the libc > locks work outside of libc for other DSOs, and libc_malloc_debug is > built with -DMODULE_NAME=libc_malloc_debug, so it should be recognized > as outside of libc. That is very strange, i686 had worked just fine on Fedora. I'll take a closer look. Thanks Siddhesh