From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3D8FA1F8C6 for ; Fri, 9 Jul 2021 09:22:44 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6E8BE3983822 for ; Fri, 9 Jul 2021 09:22:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6E8BE3983822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625822563; bh=Xz/JSYFD0ZoM4NSrl1O//tBbS9E9dVsaKF6Jdlxa8dM=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hHW7a7Qhx4Ybbxb/QJ3Vr22u4OirfLvo59PA8vnc79SJcU+CutksU5h1G54qRsJXB uxprJdxkxXXlQJ87Q50lNHiSCkET6+R3ZajhMYxTw8ApGBvJp+ywM2/9A9nRfLhOC1 f/t6WjQFxxGlqYIWRgSyYz0IY3IFw5cn85MoOZbY= Received: from cyan.elm.relay.mailchannels.net (cyan.elm.relay.mailchannels.net [23.83.212.47]) by sourceware.org (Postfix) with ESMTPS id 896E6384F01B for ; Fri, 9 Jul 2021 09:21:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 896E6384F01B X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D5D4D48124C; Fri, 9 Jul 2021 09:21:54 +0000 (UTC) Received: from pdx1-sub0-mail-a31.g.dreamhost.com (100-101-162-68.trex-nlb.outbound.svc.cluster.local [100.101.162.68]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 32327481B40; Fri, 9 Jul 2021 09:21:54 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a31.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.101.162.68 (trex/6.3.3); Fri, 09 Jul 2021 09:21:54 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Keen-Left: 7af9d4313108f264_1625822514423_2259999628 X-MC-Loop-Signature: 1625822514423:3832768657 X-MC-Ingress-Time: 1625822514422 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id E9A30852E0; Fri, 9 Jul 2021 02:21:53 -0700 (PDT) Received: from [192.168.1.137] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id 5D6E88080F; Fri, 9 Jul 2021 02:21:51 -0700 (PDT) Subject: Re: [PATCH v7 3/8] Move malloc hooks into a compat DSO To: Florian Weimer References: <20210708174325.3243721-1-siddhesh@sourceware.org> <20210708174325.3243721-4-siddhesh@sourceware.org> <874kd3ki4r.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a31 Message-ID: <8a0d57af-52f7-982b-891d-4e890d6b7d7e@sourceware.org> Date: Fri, 9 Jul 2021 14:51:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <874kd3ki4r.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Siddhesh Poyarekar via Libc-alpha Reply-To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/9/21 1:56 PM, Florian Weimer via Libc-alpha wrote: > * Siddhesh Poyarekar: > >> +void (*__malloc_initialize_hook) (void) = initialize_hooks; >> +compat_symbol_reference (libc, __malloc_initialize_hook, >> + __malloc_initialize_hook, GLIBC_2_0); > > This does not work on newer targets, which do not have > __malloc_initialize_hook. You need to replicate the same logic that is > used to define __malloc_initialize_hook in malloc/hooks.c (but with > OTHER_SHLIB_COMPAT). OK, I'll fix this. Thanks, Siddhesh