From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E16F41F4B5 for ; Wed, 20 Nov 2019 09:59:20 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=v8xQLr9hjDTTOfh6Z/7EQBw+ONXSGj5lPsxq1OWn6Xk IDcTtPjS1EwdXnu2uhMX8z1TpN2kJaEz2w3EaxhSxYMgH2GG75D/gWouc2UxhVEa CIy1zHRCP5jR+AN5zLqN9kjI9aEnG86SHo2vaZ8YGCI58He7ul4N4REmbk/BHwww = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=9VWSz9Tv2AuRzBEBc3ZSXF8Eg8M=; b=kWTgl8zTfi6ekBYY2 YYt4icGXpNyE0ZnTVI6LOnQp02fGDT0HaA+S4+8n+R75OH0QkqEWFzuHxGvIZQEk NG8FWO8rxUkGa/r0RaL5+pNsVm9zyGr1n05uUzzuVJ8sGDeLVx3qGqGR9OBt2rHl VQN7gqT9YYSsWM0NnVEzavm4Jg= Received: (qmail 29883 invoked by alias); 20 Nov 2019 09:59:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 29872 invoked by uid 89); 20 Nov 2019 09:59:17 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574243953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SOfikxBMv1YRGN6JNR7UmGIBYlbwDeZ5qWqIGA93BHA=; b=bGtAiF1fiUKzfEdnSL53w422j7oP7i12vpRNTRMyH689cgIBvMMvmZmMS4F+aiTsD/E2BF 4E6C11UWKC8gAVPARrv2DUBVULYughjwpIcGg6Ztq4T4t4POG7HEOcXvwwzWK77pk9zKBs H+O+ACTZ8BShNAg6hbm6r5RHCJ0hs1o= From: Florian Weimer To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: libc-alpha@sourceware.org, Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Subject: Re: [PATCH] rtld: Check __libc_enable_secure before honoring LD_PREFER_MAP_32BIT_EXEC References: <20191119082037.31356-1-koriakin@0x04.net> Date: Wed, 20 Nov 2019 10:59:06 +0100 In-Reply-To: <20191119082037.31356-1-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Tue, 19 Nov 2019 09:20:37 +0100") Message-ID: <87zhgqvpg5.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Given the patch is a clear improvement over what we have today, would you please repost it with the following changes: Please try to add CVE-2019-19126 to the commit subject, along with the bug number. The latter has to be of the form =E2=80=9C(bug 25204)=E2=80=9D= or =E2=80=9C[BZ #25204]=E2=80=9D, so that our tooling recongizes it. Please mention the commit which introduced the flow in the commit message, e.g. =E2=80=9Ccommit b9eb92ab05204df772eb4929eccd018637c9f3e9 ("Add Prefer_MAP_32BIT_EXEC to map executable pages with MAP_32BIT")=E2=80= =9D. It would be nice if you could write a short entry for NEWS, in the Security related changes section for the 2.31 release. If you do not want to make these changes, I can make them for you before pushing the patch. Thanks, Florian