unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Maxim Kuvyrkov via Libc-alpha <libc-alpha@sourceware.org>
Cc: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
Subject: Re: [PATCH v5] Define PTHREAD_STACK_MIN to sysconf(_SC_THREAD_STACK_MIN)
Date: Mon, 12 Jul 2021 21:50:27 +0200	[thread overview]
Message-ID: <87zgur71mk.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <58AE31E3-6592-4E3F-8554-72836C599605@linaro.org> (Maxim Kuvyrkov via Libc-alpha's message of "Mon, 12 Jul 2021 22:07:16 +0300")

* Maxim Kuvyrkov via Libc-alpha:

> Hi H.J.,
>
> This breaks GCC’s libgomp build on at least aarch64-linux-gnu:
>
> /builds/destdir/x86_64-pc-linux-gnu/aarch64-linux-gnu/bin/ld: .libs/env.o: in function `initialize_env':
> /snapshots/gcc.git~master/libgomp/env.c:1536: undefined reference to `sysconf'
> /snapshots/gcc.git~master/libgomp/env.c:1538: undefined reference to `sysconf'
> /snapshots/gcc.git~master/libgomp/env.c:1539: undefined reference to `sysconf'
> /builds/destdir/x86_64-pc-linux-gnu/aarch64-linux-gnu/bin/ld: .libs/proc.o: in function `gomp_init_num_threads':
> /snapshots/gcc.git~master/libgomp/config/linux/proc.c:85: undefined reference to `sysconf'
> /snapshots/gcc.git~master/libgomp/config/linux/proc.c:143: undefined reference to `sysconf'
> /snapshots/gcc.git~master/libgomp/config/linux/proc.c:174: more undefined references to `sysconf' follow
> collect2: error: ld returned 1 exit status
> make[4]: *** [Makefile:728: libgomp.la] Error 1
>
> Both GCC and Glibc are tip of trunk.
>
> Would you please take a look?  Please let me know if it doesn’t easily
> reproduce and I’ll take a look.

I pushed a patch today that should fix this on the glibc side:

  Reduce <limits.h> pollution due to dynamic PTHREAD_STACK_MIN
  <https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=aaacde11f2e814814f>

It contains some magic that happens to fix GCC for now.  Jakub is
working on a patch that fixes the libgomp issue as well (the standard
header #include within the hidden-visibility area is invalid):

  <https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574960.html>

Thanks,
Florian


  parent reply	other threads:[~2021-07-12 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 21:09 [PATCH v5] Define PTHREAD_STACK_MIN to sysconf(_SC_THREAD_STACK_MIN) H.J. Lu via Libc-alpha
2021-07-09 22:07 ` Carlos O'Donell via Libc-alpha
2021-07-12 19:07 ` Maxim Kuvyrkov via Libc-alpha
2021-07-12 19:45   ` H.J. Lu via Libc-alpha
2021-07-12 19:50   ` Florian Weimer via Libc-alpha [this message]
2021-07-16 22:17     ` Khem Raj via Libc-alpha
2021-07-17 21:59       ` Carlos O'Donell via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgur71mk.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=maxim.kuvyrkov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).