From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id ADBBB1F8C6 for ; Thu, 26 Aug 2021 14:26:09 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E591B385841A for ; Thu, 26 Aug 2021 14:26:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E591B385841A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629987968; bh=o2KL/R+cGbvaSPuJG2F/UfNevFXRT9UPi0DCuaNoiHY=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xDjkHLERA/dNWSaUdiIB5QPcwG1+mBpvvEWkXD9cdREjGOzUwKzCnKsom8eYEurqg VVf0ZZWHHsHsJhIE673WryiyXzgiXxkM8pcZLmIi8dUriNVjANHWiAWkQsAT9xLFOX jOLnP1dBpJWiR4WC+iha+KDJpfZgoOkRWmD4atm0= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 2A9C23858402 for ; Thu, 26 Aug 2021 14:25:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A9C23858402 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-tcscJIt6NQWl_Ps0uakVQw-1; Thu, 26 Aug 2021 10:25:47 -0400 X-MC-Unique: tcscJIt6NQWl_Ps0uakVQw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B8791008064; Thu, 26 Aug 2021 14:25:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CBAC5D9C6; Thu, 26 Aug 2021 14:25:45 +0000 (UTC) To: Adhemerval Zanella Subject: Re: [PATCH v2 11/19] nptl: Use tidlock when accessing TID on pthread_setaffinity References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-12-adhemerval.zanella@linaro.org> Date: Thu, 26 Aug 2021 16:25:43 +0200 In-Reply-To: <20210823195047.543237-12-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 23 Aug 2021 16:50:39 -0300") Message-ID: <87zgt45llk.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > Checked on x86_64-linux-gnu. > --- > nptl/pthread_setaffinity.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/nptl/pthread_setaffinity.c b/nptl/pthread_setaffinity.c > index 3bfdc63e19..beb61836a6 100644 > --- a/nptl/pthread_setaffinity.c > +++ b/nptl/pthread_setaffinity.c > @@ -27,15 +27,23 @@ int > __pthread_setaffinity_new (pthread_t th, size_t cpusetsize, > const cpu_set_t *cpuset) > { > - const struct pthread *pd = (const struct pthread *) th; > - int res; > + struct pthread *pd = (struct pthread *) th; > > - res = INTERNAL_SYSCALL_CALL (sched_setaffinity, pd->tid, cpusetsize, > - cpuset); > + /* Block all signal, since the lock is recursive and used on pthread_cancel > + (which should be async-signal-safe). */ > + sigset_t oldmask; > + __libc_signal_block_all (&oldmask); > + lll_lock (pd->tidlock, LLL_PRIVATE); > > - return (INTERNAL_SYSCALL_ERROR_P (res) > - ? INTERNAL_SYSCALL_ERRNO (res) > - : 0); > + int res = pd->tid == 0 > + ? ESRCH > + : INTERNAL_SYSCALL_CALL (sched_setaffinity, pd->tid, cpusetsize, > + cpuset); > + > + lll_unlock (pd->tidlock, LLL_PRIVATE); > + __libc_signal_restore_set (&oldmask); > + > + return res; Same issue regarding ESRCH and pthread_cancel. Here we can just return 0 in case the thread is gone, I think. Thanks, Florian