From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8A8AC1F462 for ; Tue, 4 Jun 2019 20:00:51 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-type; q=dns; s=default; b=LRWa5 eck3uP52FelnLqKpeBRUrUbs65rS5EopktsJbhv3tBc3p8vaPIFH2X9zmpqyiNi2 w6ccqXOk8dm7vz4NtQ91rBAOf79Bnh1nSD77H75gr2JmcRbyEFmkjGVRvyO71/Tb M+7Gpwo04bo+nlIgQE4rB1qfhDCY0yq9upkokM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-type; s=default; bh=25/RzbrWMN8 W3ln835ogd19diuc=; b=wtShm7t14kDfuFSZHDcf/2PNxncqn5M7AZgeF92zVm7 KhgSW7E/guNXOW908a+Lt0JkZJx8/Hn8EMZ5p2dYO4cpG2UIXC/kqyQ/MGedce79 8OwwAU+2Uty3DbpP/YoVkVG+7V94CUMj1WKhq+APHDn94ftAZRXjYH7i4qFipuK0 = Received: (qmail 125042 invoked by alias); 4 Jun 2019 20:00:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 124996 invoked by uid 89); 4 Jun 2019 20:00:48 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: aye.apple.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Vacuous-Spill: 52f01e0028fcdec8_1559678443698_187588365 X-MC-Loop-Signature: 1559678443698:3681100286 X-MC-Ingress-Time: 1559678443697 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=ascii.art.br; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=ascii.art.br; bh=25/RzbrWMN8W3ln835ogd19diuc=; b= sOuw90C/kyhJSLBg1cvgo6ZrgbQi24oEFNGMn5PSZjX5o4+E4TS8YsCccmXv1Cph sPsvAIVQHAlE/VRuq0dDKON8wjFtzPjCxvO3I3fdE8/PPBj5ceUcORqUxGeKrOQQ NxDC9l8vg78grqYLZHW3By9SBGEFeGIenZS/JP5dEvk= X-DH-BACKEND: pdx1-sub0-mail-a34 From: Tulio Magno Quites Machado Filho To: Shawn Landden , libc-alpha@sourceware.org Cc: Subject: Re: [v3 PATCH] PPC64: Add libmvec SIMD double-precision natural exponent function. In-Reply-To: <20190529191106.23888-1-shawn@git.icu> References: <87tvddl7px.fsf@linux.ibm.com> <20190529191106.23888-1-shawn@git.icu> User-Agent: Notmuch/0.27 (http://notmuchmail.org) Emacs/25.3.1 (x86_64-redhat-linux-gnu) Date: Tue, 04 Jun 2019 17:00:37 -0300 Message-ID: <87y32hjf2y.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -90 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudegtddgtdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdluddtmdenucfjughrpefhvffujghffgffkfggtgesthdtredttdertdenucfhrhhomhepvfhulhhiohcuofgrghhnohcusfhuihhtvghsucforggthhgrughoucfhihhlhhhouceothhulhhiohhmsegrshgtihhirdgrrhhtrdgsrheqnecukfhppeefvddruddtgedrudekrddvtdefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegrshgtihhirdgrrhhtrdgsrhdpihhnvghtpeefvddruddtgedrudekrddvtdefpdhrvghtuhhrnhdqphgrthhhpefvuhhlihhoucforghgnhhoucfsuhhithgvshcuofgrtghhrgguohcuhfhilhhhohcuoehtuhhlihhomhesrghstghiihdrrghrthdrsghrqedpmhgrihhlfhhrohhmpehtuhhlihhomhesrghstghiihdrrghrthdrsghrpdhnrhgtphhtthhopehlihgstgdqrghlphhhrgesshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd Shawn Landden writes: > [BZ #24209] > * NEWS: Noted the addition of PPC64 vector exp function. > * sysdeps/powerpc/bits/math-vector.h: Added entry for vector exp. > * sysdeps/powerpc/powerpc64/fpu/Versions: Added vector exp entry. > * sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile: > (libmvec-sysdep_routines, CFLAGS-vec_d_exp2_vsx.c): > (CFLAGS-vec_d_exp_data.c): Added build of VSX SIMD expf > function and tests. Added vec_math_err.c to build. > * sysdeps/powerpc/powerpc64/fpu/multiarch/(math_config.h)->(math_config_dbl.h) > Renamed, and modified for exp. > * sysdeps/powerpc/powerpc64/fpu/multiarch/test-double-vlen2-wrappers.c: > Added entry for vector exp. > * sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp2_vsx.c: New file. > * sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp_data.c: Likewise. > * sysdeps/powerpc/powerpc64/fpu/multiarch/vec_math_err.c: Likewise. > * sysdeps/unix/sysv/linux/powerpc/powerpc64/libmvec.abilist: SIMD expf > added. > * sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_log_data.c: Rename of math_config.h > * sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_log2_vsx.c: Likewise Looks like some of the issues you fixed in v2 got reverted here. Fixed. > diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp2_vsx.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp2_vsx.c > new file mode 100644 > index 0000000000..376531e32b > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp2_vsx.c > ... > +/* Top 12 bits of a double (sign and exponent bits). */ > +static inline uint32_t top12(double x) > +{ > + return asuint64(x) >> 52; > +} Something happened here as well and all the coding style issues that you fixed in v2 got lost. Starting from this function. Fixed. I'm pushing this patch with the fixes I mentioned to branch tuliom/libmvec. Thanks! -- Tulio Magno