From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D259C1F45E for ; Thu, 20 Feb 2020 07:54:42 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=E13nqRmpADyjhXPuvDWTg4IpCRszMcVwh9h6tazSW92 JrHARYM+eafal62VVTp5xW3liAqa602728sB4L2Rx7El3De9GWWqfpmwbE1m0p14 M7FLD/lTxbolIzzNoU1SbjIxBBvgvGKGzaAaSUBsgo5fPGgY7pL6CL1k5omTll44 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=8gqK9+1nK03oFLF3eD1/j73KSyg=; b=vUW/MqKiBYGYOllsw KXBqPDswfkhr+tRompnhoGCf2fVo5KFyrFvFChZuN9zbksVl94aF7rTKwRB+kQca PKwdXb5D6gLI9U5LSvJZH5Yb5034fEbFbx2GbLp3B1UVJ8buPqS3RrfaRynNyq+R T9RKR6kvmWXh9rg1Aij4OzvRAw= Received: (qmail 54651 invoked by alias); 20 Feb 2020 07:54:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 54641 invoked by uid 89); 20 Feb 2020 07:54:39 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582185277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7TJ75leeJmASXPVHFO3PdsGE4/QOAE1oKz0pJV7A3qw=; b=UsQqP17+IbRb82M4mfxc3hkwgACKV03WsWuqbR0Ex402EfR8eLg+HMwm8L16hU5FwQfnHI lQDD7yR89KXn/EWFHFUvyCaq8T/NAv/xIVg2Plr5LyeP/2canSb2z3zY3YTRLLm3iSE6Kr uohECoGCMIiC9eS/uVcNCN+ADEOf4XQ= From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 02/13] nptl: Sort routines list in Makefile alphabetically References: <87037a063582b22acaede4def0245c5042fd8e22.1581418947.git.fweimer@redhat.com> <6611e064-469a-d845-7a48-7f6a9df6c594@linaro.org> Date: Thu, 20 Feb 2020 08:54:30 +0100 In-Reply-To: <6611e064-469a-d845-7a48-7f6a9df6c594@linaro.org> (Adhemerval Zanella's message of "Wed, 19 Feb 2020 14:34:24 -0300") Message-ID: <87y2sxg0cp.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: > On 11/02/2020 08:06, Florian Weimer wrote: >> This will make it easier to review changes which move implementations >> from libpthread to libc. > > This organization does help a lot not only refactoring, but also new > files. Maybe we could enforce it from now one, thoughts? We are using this construct in a few other places. Andreas did not like the final line with the trailing \ though. routines +=3D function would avoid that, but it has quadratic behavior in make, and that could be actually visible in a few places. > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella Thanks for all the reviews. FlFlorian