From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5BC2E1F8C6 for ; Wed, 28 Jul 2021 04:59:20 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BCB3A3877402 for ; Wed, 28 Jul 2021 04:59:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BCB3A3877402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627448356; bh=RxPUZztzpqZouItTix/jL1UqAxMwdxG/rVbfeJX266A=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jX32YDd8Wf6bxhuTbO35HI//AK2z0zedlBs9DGtj5W90tDiaiVffWnWbOP8uOuRQa tpVyOI0jkCFyoNZwDYwShMwqRJg2evbdS7gfirLU9cRA5qHD2CiTRRAYsP/+AFZ8rd o0bvJ4oOu32o8akIteE5Bj6rmKuW9prGJRnVqk0Q= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 2B8F2383D03A for ; Wed, 28 Jul 2021 04:58:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B8F2383D03A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-AFRTOmhgPLCqKnXvTNJyHQ-1; Wed, 28 Jul 2021 00:58:55 -0400 X-MC-Unique: AFRTOmhgPLCqKnXvTNJyHQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F99F1006C92; Wed, 28 Jul 2021 04:58:54 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66BA918649; Wed, 28 Jul 2021 04:58:53 +0000 (UTC) To: "Andreas K. Huettel via Libc-alpha" Subject: Re: RFC: Disable clone3 for glibc 2.34 References: <87eebkf8ph.fsf@oldenburg.str.redhat.com> <5551022.NgBsaNRSFp@pinacolada> Date: Wed, 28 Jul 2021 06:58:51 +0200 In-Reply-To: <5551022.NgBsaNRSFp@pinacolada> (Andreas K. Huettel via Libc-alpha's message of "Wed, 28 Jul 2021 01:07:19 +0200") Message-ID: <87y29r9gqc.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Andreas K. Huettel via Libc-alpha: > Semi-related... > >> int ret; >> -#ifdef HAVE_CLONE3_WAPPER >> - /* Try clone3 first. */ >> - int saved_errno = errno; > > shouldn't this be WRAPPER ? > > (It seems to be consistent in the code, so no harm done so far...) Yes, it should be. And yes, it's currently consistent. But it's confusing if you search for it and don't make the typo. Thanks, Florian