From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DA8521F8C6 for ; Fri, 30 Jul 2021 06:12:45 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5C3E385841F for ; Fri, 30 Jul 2021 06:12:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5C3E385841F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627625564; bh=ZztSSVdPi/1McyOw5Vjws4hrCOociJiA0Ogbop2zWQs=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qERm0zaFKBmWeZ8KFXkZCKldDBDUXikwVVyCSL/vcfKU1/T4BIlZHrVl3kU7TKVXa d6g2/UmYPVPpCuwE+uFxwMJHotfSV00Q+Wuio/laQBtpeIk06KKGGBmW/VrKHJE4Z/ SKPH2OBo0dfvGmIVeeZuJRWR5d0+LwmK5XTnrOP4= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 77CE1385842C for ; Fri, 30 Jul 2021 06:11:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77CE1385842C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-AQ6L1vwfMD6X3QW-NFjg_w-1; Fri, 30 Jul 2021 02:11:17 -0400 X-MC-Unique: AQ6L1vwfMD6X3QW-NFjg_w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB08C107465F for ; Fri, 30 Jul 2021 06:11:16 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D1D010016F4; Fri, 30 Jul 2021 06:11:12 +0000 (UTC) To: Carlos O'Donell via Libc-alpha Subject: Re: [PATCH v5 1/2] Add 'strcmp_collation' support for LC_COLLATE. References: <20210730043218.3701358-1-carlos@redhat.com> <20210730043218.3701358-2-carlos@redhat.com> Date: Fri, 30 Jul 2021 08:11:10 +0200 In-Reply-To: <20210730043218.3701358-2-carlos@redhat.com> (Carlos O'Donell via Libc-alpha's message of "Fri, 30 Jul 2021 00:32:17 -0400") Message-ID: <87y29oz5z5.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Carlos O'Donell via Libc-alpha: > @@ -2123,6 +2135,20 @@ collate_output (struct localedef_t *locale, const struct charmap_t *charmap, > /* The words have to be handled specially. */ > if (idx == _NL_ITEM_INDEX (_NL_COLLATE_SYMB_HASH_SIZEMB)) > add_locale_uint32 (&file, 0); > + else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_CODESET) > + && collate != NULL) > + /* A valid LC_COLLATE must have a code set name. */ > + add_locale_string (&file, charmap->code_set_name); > + else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_COLLSEQMB) > + && collate != NULL) > + { > + add_locale_raw_data (&file, collseqmb, 256); > + } > + else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_COLLSEQWC) > + && collate != NULL) > + { > + add_locale_raw_data (&file, collseqwc, sizeof (collseqwc)); > + } > else > add_locale_empty (&file); The braces are inconsistent. And I think collseqwc needs to be written using add_locale_uint32_array, to support --big-endian/--little-endian. Thanks, Florian