Re: [PATCH v5 1/2] Add 'strcmp_collation' support for LC_COLLATE.

[Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>]

* Carlos O'Donell via Libc-alpha:

> @@ -2123,6 +2135,20 @@ collate_output (struct localedef_t *locale, const struct charmap_t *charmap,
>  	  /* The words have to be handled specially.  */
>  	  if (idx == _NL_ITEM_INDEX (_NL_COLLATE_SYMB_HASH_SIZEMB))
>  	    add_locale_uint32 (&file, 0);
> +	  else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_CODESET)
> +		   && collate != NULL)
> +	    /* A valid LC_COLLATE must have a code set name.  */
> +	    add_locale_string (&file, charmap->code_set_name);
> +	  else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_COLLSEQMB)
> +		   && collate != NULL)
> +	    {
> +	      add_locale_raw_data (&file, collseqmb, 256);
> +	    }
> +	  else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_COLLSEQWC)
> +		   && collate != NULL)
> +	    {
> +	      add_locale_raw_data (&file, collseqwc, sizeof (collseqwc));
> +	    }
>  	  else
>  	    add_locale_empty (&file);

The braces are inconsistent.  And I think collseqwc needs to be written
using add_locale_uint32_array, to support --big-endian/--little-endian.

Thanks,
Florian