unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>,
	naohirot--- via Libc-alpha <libc-alpha@sourceware.org>,
	Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: Re: [PATCH] AArch64: Update A64FX memset not to degrade at 16KB
Date: Thu, 16 Sep 2021 13:53:53 +0200	[thread overview]
Message-ID: <87y27wlory.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2109061547400.1679711@digraph.polyomino.org.uk> (Joseph Myers's message of "Mon, 6 Sep 2021 15:54:14 +0000")

* Joseph Myers:

> On Mon, 6 Sep 2021, Florian Weimer via Libc-alpha wrote:
>
>> Unfortunately, we do not have much control over the mailing list
>> configuration (to make “git am” work) or the commit hooks (to prevent
>> people from pushing such changes).  Sorry about that.
>
> We do have sufficient control over the git hooks.  You can set 
> commit-extra-checker (in refs/meta/config:project.config) to point to a 
> script that applies such checks to commits.  See 
> /git/gcc.git/hooks-bin/commit_checker for example; that includes code:
>
>     # Reject commits applied via "git am" with list email address as
>     # the author.
>     if author_email in ('gcc-patches@gcc.gnu.org', 'libstdc++@gcc.gnu.org',
>                         'fortran@gcc.gnu.org'):
>         error('When applying a patch from a mailing list, make sure '
>               'to use the original name and email address of the patch '
>               'author, not the list email address with "via Gcc-patches".')
>
> These checks are only applied to commits new to the repository, not 
> commits new to a particular branch but already present in the repository, 
> so applying stricter checks to new commits on particular branches can be 
> trickier (see <https://github.com/AdaCore/git-hooks/issues/20>), but for 
> this particular issue a branch-independent check should suffice.

I've tried to implement this now.  commit-extra-checker now points to a
trimmed-down version of the GCC script.

Thanks,
Florian


  reply	other threads:[~2021-09-16 11:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27  5:03 [PATCH] AArch64: Update A64FX memset not to degrade at 16KB Naohiro Tamura via Libc-alpha
2021-09-03 15:01 ` Szabolcs Nagy via Libc-alpha
2021-09-05 23:51   ` naohirot--- via Libc-alpha
2021-09-06  0:16     ` naohirot--- via Libc-alpha
2021-09-06  6:17       ` Florian Weimer via Libc-alpha
     [not found]         ` <TYAPR01MB602525FB59480A6CEF989F9CDFD29@TYAPR01MB6025.jpnprd01.prod.outlook.com>
2021-09-06  8:44           ` naohirot--- via Libc-alpha
2021-09-06 10:20             ` 'Szabolcs Nagy' via Libc-alpha
2021-09-06 11:56               ` naohirot--- via Libc-alpha
2021-09-06 15:54         ` Joseph Myers
2021-09-16 11:53           ` Florian Weimer via Libc-alpha [this message]
2021-09-17  0:49             ` naohirot--- via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y27wlory.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).