From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E88AE1F44D for ; Mon, 11 Mar 2024 16:13:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bLpegiiq; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD7C73858429 for ; Mon, 11 Mar 2024 16:13:52 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 327303858C66 for ; Mon, 11 Mar 2024 16:13:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 327303858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 327303858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710173614; cv=none; b=VG6ICHl56+AMPjc/QWz6oY5VOZGE6BdBdlL1xwMkaIV2xnHxe545lxw9eQnfIO6rSDdRkrqeEBGtAlQYJER8OkpMy5CH8ofHlL5ZYYuhpu13ccPDC1DHBb+vktq/ao7rb0GvRaQxExdib9mwQqw48NHBW34AxRtEROwrDsrcY4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710173614; c=relaxed/simple; bh=5cy0/0r57m1/dWsRSoJs0LFix4wrHrxxQPziS7+c9w8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eMx+2uFrKWiMKrbmlIBrIIwW8xkdsIC2yT257HBxfnXEd4v7kbNT0y8GYu5Ao2Ad4ZwJRobgILKuqH4SO/WcM64V4Ev6eFFKrV4B/QIsVkDneMkLp6eKKXw6A+EXnCedZ/DaxbqyotfTVq5QX43ThoP17lJJM3BmpyvH/lGjFhI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710173612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gM5I6gXtSiSvpFYyg9E/RDb4tVQ23ga7ZaWK6Z8JtYo=; b=bLpegiiqSM8uKaLGVkLEiSaLhLHyC67xiuGGkuMI/RH6d7+KUR1p9cKGKuRlqw4ryXiSRM Vnrio9VGmgoj5woXr/B8Gt+Ab0MSjraDMZIZsoof67mzg3tJhuBWY13F4qCim0gC0CTANu u/l0ckYtTG47Lp6/tmj70V2CATyqus4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-1BDwmN21PYedL5sFKOdknQ-1; Mon, 11 Mar 2024 12:13:30 -0400 X-MC-Unique: 1BDwmN21PYedL5sFKOdknQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 50A8538562D4; Mon, 11 Mar 2024 16:13:30 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7830CC0186C; Mon, 11 Mar 2024 16:13:29 +0000 (UTC) From: Florian Weimer To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH 03/23] Allow glibc to be compiled without EXEC_PAGESIZE References: <20240103171502.1358371-1-bugaevc@gmail.com> <20240103171502.1358371-4-bugaevc@gmail.com> Date: Mon, 11 Mar 2024 17:13:27 +0100 In-Reply-To: <20240103171502.1358371-4-bugaevc@gmail.com> (Sergey Bugaev's message of "Wed, 3 Jan 2024 20:14:36 +0300") Message-ID: <87y1aon3vc.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org * Sergey Bugaev: > diff --git a/elf/dl-support.c b/elf/dl-support.c > index 2f502c8b..6375dc95 100644 > --- a/elf/dl-support.c > +++ b/elf/dl-support.c > @@ -135,7 +135,11 @@ void *_dl_random; > #include > #include > > -size_t _dl_pagesize = EXEC_PAGESIZE; > +size_t _dl_pagesize > +#ifdef EXEC_PAGESIZE > + = EXEC_PAGESIZE > +#endif > +; I think the intent here is to initialize _dl_pagesize with a conservative default, to avoid initialization ordering issues. EXEC_PAGESIZE is supposed to be largest supported page size. Thanks, Florian