From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3A9C11F4B5 for ; Thu, 21 Nov 2019 13:20:52 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=yMma1I0TcaSJGBPyZW+Qhz8dVCVe3APn+F54JJAP0Ay A7Kjm/HmjhUsH+03JwFvivcnLjhkKcxidw3yhAKDq39NzLiYNFng9wVhR3k9qdgo gvdDTjGQoBdGJ1C4Boew2H8RcyEEA3kpruFK3m/zaNGY0ywhXMF0/cG7pl4Oe60A = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=cwLiALiu04BqbjtkuOxEh8TWT0Y=; b=C7xDyesSBGhbjL+oR UAMEMDLyoaUEgxXpXhrbjmfCpcmFnHcigRPtZ6K76tFmJCMtSHMHPwWxF4ZjNfed g2e3Ycrd2l5y5BxV42FPzmwCEx2lHwozJeQHbuvn+eBd39OvY8c3IvlRR5S/xASt tFv8JO8eBQiLeq5yAfIItkrq6M= Received: (qmail 129256 invoked by alias); 21 Nov 2019 13:20:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 129248 invoked by uid 89); 21 Nov 2019 13:20:49 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574342447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OAG6Q/FKG9QxlOm0ESLUnuwN9ig/iEP61DNWM3761GU=; b=BwZ8e5DHl2FOpwvyx6XuA5LF6pas86aHp0kLcO5AbasclRKA2y5KI28duWoQ8nuLPO8HaJ Wtn9Ymy0v4L7gxAqUm16pBeWXRdqETtXifmYrojLrXb/qJCVt7kS5B+hx5hYJV04UNolnQ 2asE48Na4NqVsGfbj4UcNuDTn0Y7OmY= From: Florian Weimer To: Andreas Schwab Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142) References: <87lfs9o1q7.fsf@oldenburg2.str.redhat.com> Date: Thu, 21 Nov 2019 14:20:40 +0100 In-Reply-To: (Andreas Schwab's message of "Thu, 21 Nov 2019 14:14:20 +0100") Message-ID: <87wobtmklz.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable * Andreas Schwab: > On Nov 21 2019, Florian Weimer wrote: > >> * Andreas Schwab: >> >>> During exit, skip files that are currently locked to avoid deadlock. >> >> Which locks are taken during the deadlock? > > Presumably any FILE locks, if there are other threads still running. Okay, so the problem is simply lack of progress after calling exit? >> Does this fix or re-open bug 15142? > > Why re-open? Lack of flushing of streams on process exit. >>> + /* We want to skip locked streams. Some threads might use streams b= ut >>> + that is their problem, we don't flush those. */ >>> + int result =3D _IO_flush_all_lockp (true); >> >> Is this still conforming to POSIX? > > Are deadlocks conforming to POSIX? I think the last time we discussed this, the conclusion was that lack of progress was conforming to POSIX (actually required by it). What has changed since then? Thanks, Florian