From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 328A01F463 for ; Tue, 31 Dec 2019 16:05:14 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=SCJVn 3JgvXO9m6EKJ9rNaY2qexpF7ZLM+RI9QLvxjraKWhXZhTArArE3ddknHnMuFtXYH cSGq8bfSyLZMsU8kJi1Rrx4JG+Rpk8tcujGaz5cukG5Xu8mv2nVPoVx+NuXntsz4 MAE5CO0mP3Jx/wO0MN14rXo41BoxRSZTCCPUvM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=cY0qOCTQXfA VbB1feYyJ3AJasoo=; b=uPBSb0VLCKQ7pXorFp5Mnzf2Ck29To1eu9axxHRLs5G 3TItx4P1kfssrvRq/KXAtNdIDSu58mcyP62RAU3aWW3DGQ+03yM7LR7ECoRbBwwM e+h/mMFMWhfTwSV3No6tjguOZvQpuUi9P8QiGpve2KuoXk0S2aczM/JH/PQHMVLo = Received: (qmail 66399 invoked by alias); 31 Dec 2019 16:05:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 66391 invoked by uid 89); 31 Dec 2019 16:05:11 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: albireo.enyo.de From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/5] Linux: Add tables with system call numbers References: <56247f60-bee7-9624-37bf-1453c06c7088@gotplt.org> <87zhf8n3j4.fsf@mid.deneb.enyo.de> <0b6f5557-e67f-b92f-269d-163c8df2d3c8@gotplt.org> Date: Tue, 31 Dec 2019 17:04:18 +0100 In-Reply-To: <0b6f5557-e67f-b92f-269d-163c8df2d3c8@gotplt.org> (Siddhesh Poyarekar's message of "Tue, 31 Dec 2019 21:20:13 +0530") Message-ID: <87woaclbwd.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain * Siddhesh Poyarekar: > On 31/12/19 4:52 pm, Florian Weimer wrote: >>> Prefix the auto-generated files with a comment header like so: >>> >>> /* AUTOGENERATED by update-syscall-lists.py. DO NOT EDIT. */ >> >> I'm concerned that this unnecessarily makes processing by tools more >> difficult, so I'd like to avoid this. > > The tools only need to filter out \/\*.*\*\/ (or een simpler, omit the > first line if it's just for these files) which shouldn't be more than a > line or two of code. Do you see any other challenges here? It's a very > useful comment IMO and definitely worth the extra line of code one would > have to add to omit comments or even the first line. I'll see what I can do about this. It will require quite a bit re-testing. >> But we need locking if this is used from build-many-glibcs.py, >> otherwise we'll lose updates even with the rename approach. Locking >> the file being updated is the easiest way to achieve this. It's true >> that we have data loss if the script is terminated between the >> truncate and seek, but most editors have the same issue. Therefore, I >> want to leave this as-is. > > It would be nice to make build-many-glibcs.py smarter about this. The > problem with locking seems limited to syscall-names.list and not > arch-syscalls.h since the latter ought to be different files for > build-many-glibcs, right? No, there are system call tables which are shared across tuples, e.g. little-endian and big-endian variants. These also get updated multiple times. The only alternative would be to lock a different file, perhaps sysdeps/unix/sysv/linux/Makefile. I don't know the impact yet on the execution time.