unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Xi Ruoyao via Libc-alpha <libc-alpha@sourceware.org>
Cc: Alejandro Colomar <alx.manpages@gmail.com>,
	Xi Ruoyao <xry111@xry111.site>
Subject: Re: bind(2): Missing [[gnu::nonnull]]
Date: Sat, 03 Dec 2022 20:05:33 +0100	[thread overview]
Message-ID: <87wn78cnpe.fsf@igel.home> (raw)
In-Reply-To: <8292ef824696e0fbac4f4ed036aad43c0458b8a2.camel@xry111.site> (Xi Ruoyao via Libc-alpha's message of "Sat, 03 Dec 2022 23:55:06 +0800")

On Dez 03 2022, Xi Ruoyao via Libc-alpha wrote:

> Currently the man page says:
>
> EFAULT: addr points outside the user's accessible address space.
>
> And bind(2) indeed sets errno to EFAULT and return -1 when NULL is
> passed as addr.

You can never depend on EFAULT for invalid addresses.

> gnu::nonnull is not only a diagnostic attribute: it also allows the
> compiler to assume addr is never NULL.  i. e. if addr was gnu::nonnull
> and bind(2) is called with addr == NULL, the behavior would be
> undefined.

It is already undefined now, so this would be a valid change.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  parent reply	other threads:[~2022-12-03 19:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-03 15:33 bind(2): Missing [[gnu::nonnull]] Alejandro Colomar via Libc-alpha
2022-12-03 15:55 ` Xi Ruoyao via Libc-alpha
2022-12-03 16:41   ` Alejandro Colomar via Libc-alpha
2022-12-03 19:05   ` Andreas Schwab [this message]
2022-12-03 19:12     ` Alejandro Colomar via Libc-alpha
2022-12-04  5:59     ` Xi Ruoyao via Libc-alpha
2022-12-04 11:14       ` Alejandro Colomar via Libc-alpha
2022-12-04 18:46         ` Florian Weimer via Libc-alpha
2022-12-05 18:53           ` Zack Weinberg via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn78cnpe.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=alx.manpages@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).