unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] elf: Also compile dl-misc.os with $(rtld-early-cflags)
Date: Thu, 25 Apr 2024 17:00:25 +0200	[thread overview]
Message-ID: <87wmol4hdi.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20240425145425.309747-1-hjl.tools@gmail.com> (H. J. Lu's message of "Thu, 25 Apr 2024 07:54:24 -0700")

* H. J. Lu:

> Also compile dl-misc.os with $(rtld-early-cflags) to avoid
>
> Program received signal SIGILL, Illegal instruction.
> 0x00007ffff7fd36ea in _dl_strtoul (nptr=nptr@entry=0x7fffffffe2c9 "2",
>     endptr=endptr@entry=0x7fffffffd728) at dl-misc.c:156
> 156	  bool positive = true;
> (gdb) bt
>  #0  0x00007ffff7fd36ea in _dl_strtoul (nptr=nptr@entry=0x7fffffffe2c9 "2",
>     endptr=endptr@entry=0x7fffffffd728) at dl-misc.c:156
>  #1  0x00007ffff7fdb1a9 in tunable_initialize (
>     cur=cur@entry=0x7ffff7ffbc00 <tunable_list+2176>,
>     strval=strval@entry=0x7fffffffe2c9 "2", len=len@entry=1)
>     at dl-tunables.c:131
>  #2  0x00007ffff7fdb3a2 in parse_tunables (valstring=<optimized out>)
>     at dl-tunables.c:258
>  #3  0x00007ffff7fdb5d9 in __GI___tunables_init (envp=0x7fffffffdd58)
>     at dl-tunables.c:288
>  #4  0x00007ffff7fe44c3 in _dl_sysdep_start (
>     start_argptr=start_argptr@entry=0x7fffffffdcb0,
>     dl_main=dl_main@entry=0x7ffff7fe5f80 <dl_main>)
>     at ../sysdeps/unix/sysv/linux/dl-sysdep.c:110
>  #5  0x00007ffff7fe5cae in _dl_start_final (arg=0x7fffffffdcb0) at rtld.c:494
>  #6  _dl_start (arg=0x7fffffffdcb0) at rtld.c:581
>  #7  0x00007ffff7fe4b38 in _start ()
> (gdb)
>
> when glibc is compiled with APX.

Maybe mention setting GLIBC_TUNABLES as the trigger in the commit
message?

Otherwise:

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


  reply	other threads:[~2024-04-25 15:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 14:54 [PATCH v2] elf: Also compile dl-misc.os with $(rtld-early-cflags) H.J. Lu
2024-04-25 15:00 ` Florian Weimer [this message]
2024-04-25 15:08   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmol4hdi.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).