From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4353F211B3 for ; Fri, 30 Nov 2018 17:36:58 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=uQ5c+ GpM3nKXFbuCOxBylUDqPYSusKVPnR0B4MHvRNZUGzgBo0P+x3i+iiMgk+YCbgUia g3Yv0wTgeGOxjOGVPYhK5SLb/uwrWfuaczeHJoCDWSZqFLr3zZBE+CpT6ABcZP6h Nz1YcQYxXRNupQm+0I7yx0pO5A4X6VfTpkHbng= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=eaZSl0svOqP +eINxynlUywiFtN0=; b=hKg1784H4Uv+/AjLKJrpucTz7Em7vSEg/xEgFbc8f2r Yx2CZrEwjzw63JgsWNDwh+M1lC54PBkSsDpWoAGUvR3g8PKD5JMTA36l4Ym5IhTS /nxVZsU7j/1fHGB+/HRhOtq+4sO5FJFdnJB6CrOwSiGbxOi0HazfOUTM63xPs6hk = Received: (qmail 103903 invoked by alias); 30 Nov 2018 17:36:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 103890 invoked by uid 89); 30 Nov 2018 17:36:55 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Stefan Liebler Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 02/56] S390: Use hwcap instead of dl_hwcap in ifunc-resolvers. References: <1543593514-10251-1-git-send-email-stli@linux.ibm.com> <1543593514-10251-3-git-send-email-stli@linux.ibm.com> Date: Fri, 30 Nov 2018 18:36:36 +0100 In-Reply-To: <1543593514-10251-3-git-send-email-stli@linux.ibm.com> (Stefan Liebler's message of "Fri, 30 Nov 2018 16:57:40 +0100") Message-ID: <87va4eqxgb.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Stefan Liebler: > + if (__glibc_likely((hwcap & HWCAP_S390_STFLE) \ Missing space before paren. Since HWCAP_S390_STFLE 4 is four, this __glibc_likely is actually equivalent to __glibc_unlikely, so perhaps you should drop it. Thanks, Florian