From: Florian Weimer <fweimer@redhat.com>
To: Stefan Liebler <stli@linux.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 02/56] S390: Use hwcap instead of dl_hwcap in ifunc-resolvers.
Date: Fri, 30 Nov 2018 18:36:36 +0100 [thread overview]
Message-ID: <87va4eqxgb.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <1543593514-10251-3-git-send-email-stli@linux.ibm.com> (Stefan Liebler's message of "Fri, 30 Nov 2018 16:57:40 +0100")
* Stefan Liebler:
> + if (__glibc_likely((hwcap & HWCAP_S390_STFLE) \
Missing space before paren. Since HWCAP_S390_STFLE 4 is four, this
__glibc_likely is actually equivalent to __glibc_unlikely, so perhaps
you should drop it.
Thanks,
Florian
next prev parent reply other threads:[~2018-11-30 17:36 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 15:57 [PATCH] S390: Refactor ifunc handling Stefan Liebler
2018-11-30 15:57 ` [PATCH 01/56] S390: Add configure check to detect z10 as mininum architecture level set Stefan Liebler
2018-11-30 15:57 ` [PATCH 02/56] S390: Use hwcap instead of dl_hwcap in ifunc-resolvers Stefan Liebler
2018-11-30 17:36 ` Florian Weimer [this message]
2018-12-03 8:20 ` Stefan Liebler
2018-12-03 16:28 ` Florian Weimer
2018-11-30 15:57 ` [PATCH 03/56] S390: Unify 31/64bit memset Stefan Liebler
2018-11-30 15:57 ` [PATCH 04/56] S390: Refactor memset ifunc handling Stefan Liebler
2018-11-30 15:57 ` [PATCH 05/56] S390: Implement bzero with memset Stefan Liebler
2018-11-30 15:57 ` [PATCH 06/56] S390: Unify 31/64bit memcmp Stefan Liebler
2018-11-30 15:57 ` [PATCH 07/56] S390: Refactor memcmp ifunc handling Stefan Liebler
2018-11-30 15:57 ` [PATCH 08/56] S390: Unify 31/64bit memcpy Stefan Liebler
2018-11-30 15:57 ` [PATCH 09/56] S390: Refactor memcpy/mempcpy ifunc handling Stefan Liebler
2018-11-30 15:57 ` [PATCH 10/56] S390: Remove s390 specific implementation of bcopy Stefan Liebler
2018-11-30 15:57 ` [PATCH 11/56] S390: Use memcpy for forward cases in memmove Stefan Liebler
2018-11-30 15:57 ` [PATCH 12/56] S390: Add configure check to detect z13 as mininum architecture level set Stefan Liebler
2018-11-30 15:57 ` [PATCH 13/56] S390: Add z13 memmove ifunc variant Stefan Liebler
2018-11-30 15:57 ` [PATCH 14/56] S390: Add z13 strstr " Stefan Liebler
2018-11-30 15:57 ` [PATCH 15/56] S390: Add z13 memmem " Stefan Liebler
2018-11-30 15:57 ` [PATCH 16/56] S390: Refactor strlen ifunc handling Stefan Liebler
2018-11-30 15:57 ` [PATCH 17/56] S390: Refactor strnlen " Stefan Liebler
2018-11-30 15:57 ` [PATCH 18/56] S390: Refactor strcpy " Stefan Liebler
2018-11-30 15:57 ` [PATCH 19/56] S390: Refactor stpcpy " Stefan Liebler
2018-11-30 15:57 ` [PATCH 20/56] S390: Refactor strncpy " Stefan Liebler
2018-11-30 15:57 ` [PATCH 21/56] S390: Refactor stpncpy " Stefan Liebler
2018-11-30 15:58 ` [PATCH 22/56] S390: Refactor strcat " Stefan Liebler
2018-11-30 15:58 ` [PATCH 23/56] S390: Refactor strncat " Stefan Liebler
2018-11-30 15:58 ` [PATCH 24/56] S390: Refactor strcmp " Stefan Liebler
2018-11-30 15:58 ` [PATCH 25/56] S390: Refactor strncmp " Stefan Liebler
2018-11-30 15:58 ` [PATCH 26/56] S390: Refactor strchr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 27/56] S390: Refactor strchrnul " Stefan Liebler
2018-11-30 15:58 ` [PATCH 28/56] S390: Refactor strrchr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 29/56] S390: Refactor strspn " Stefan Liebler
2018-11-30 15:58 ` [PATCH 30/56] S390: Refactor strpbrk " Stefan Liebler
2018-11-30 15:58 ` [PATCH 31/56] S390: Refactor strcspn " Stefan Liebler
2018-11-30 15:58 ` [PATCH 32/56] S390: Refactor memchr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 33/56] S390: Refactor rawmemchr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 34/56] S390: Refactor memccpy " Stefan Liebler
2018-11-30 15:58 ` [PATCH 35/56] S390: Refactor memrchr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 36/56] S390: Refactor wcslen " Stefan Liebler
2018-11-30 15:58 ` [PATCH 37/56] S390: Refactor wcsnlen " Stefan Liebler
2018-11-30 15:58 ` [PATCH 38/56] S390: Refactor wcscpy " Stefan Liebler
2018-11-30 15:58 ` [PATCH 39/56] S390: Refactor wcpcpy " Stefan Liebler
2018-11-30 15:58 ` [PATCH 40/56] S390: Refactor wcsncpy " Stefan Liebler
2018-11-30 15:58 ` [PATCH 41/56] S390: Refactor wcpncpy " Stefan Liebler
2018-11-30 15:58 ` [PATCH 42/56] S390: Refactor wcscat " Stefan Liebler
2018-11-30 15:58 ` [PATCH 43/56] S390: Refactor wcsncat " Stefan Liebler
2018-11-30 15:58 ` [PATCH 44/56] S390: Refactor wcscmp " Stefan Liebler
2018-11-30 15:58 ` [PATCH 45/56] S390: Refactor wcsncmp " Stefan Liebler
2018-11-30 15:58 ` [PATCH 46/56] S390: Refactor wcschr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 47/56] S390: Refactor wcschrnul " Stefan Liebler
2018-11-30 15:58 ` [PATCH 48/56] S390: Refactor wcsrchr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 49/56] S390: Refactor wcsspn " Stefan Liebler
2018-11-30 15:58 ` [PATCH 50/56] S390: Refactor wcspbrk " Stefan Liebler
2018-11-30 15:58 ` [PATCH 51/56] S390: Refactor wcscspn " Stefan Liebler
2018-11-30 15:58 ` [PATCH 52/56] S390: Refactor wmemchr " Stefan Liebler
2018-11-30 15:58 ` [PATCH 53/56] S390: Refactor wmemset " Stefan Liebler
2018-11-30 15:58 ` [PATCH 54/56] S390: Refactor wmemcmp " Stefan Liebler
2018-11-30 15:58 ` [PATCH 55/56] S390: Refactor gconv_simple " Stefan Liebler
2018-11-30 15:58 ` [PATCH 56/56] S390: Cleanup ifunc-resolve.h Stefan Liebler
2018-11-30 18:31 ` [PATCH] S390: Refactor ifunc handling Adhemerval Zanella
2018-12-03 8:48 ` Stefan Liebler
2018-12-03 17:30 ` Adhemerval Zanella
2018-12-05 16:15 ` Stefan Liebler
2018-12-05 19:32 ` Adhemerval Zanella
2018-12-06 16:54 ` Stefan Liebler
2018-12-06 18:13 ` Adhemerval Zanella
2018-12-06 20:47 ` Joseph Myers
2018-12-07 13:09 ` Stefan Liebler
2018-12-07 13:09 ` Stefan Liebler
2018-12-11 14:46 ` Stefan Liebler
2018-12-18 13:03 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va4eqxgb.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).