From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AF9871F45E for ; Tue, 11 Feb 2020 11:21:42 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=oAUghMALYCQS4VezjbZyv2ZNqhBQ0tsjJQWs7Who+bD QUQEhIzwzcGs1OljC6dDvbfkyvSZ4azYuV7I/xeFhtjVpqBchU5sSDwO2/a2ZLro bnNzDOCf4BhdpiZ72WiyQDTzWAFKrpVIixrb8jlRfYpXed6DQTZ42R8RFRTMb5rI = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=SfG4KKyktyZlXXE/pKZGuQD+LjI=; b=kPCf5EnpsMnZAaMEz MRTcUzvgGrCvWbedRlh96Wi2OFt8mO9uMRuF1IRIggV4Mp6c2/q2xUPbTLMd93u7 gVLaJyo+kkCFlAqrM+bLWNDhWgdRls0qj/iubxAvmwvQKpa8akWwfO7xgSRsJhA1 I56zictJwZ4oSecTrE1BM1Eiu0= Received: (qmail 120196 invoked by alias); 11 Feb 2020 11:21:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 120182 invoked by uid 89); 11 Feb 2020 11:21:39 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581420097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WI0QdnKFLy+gDWFm0bipXUdORV7u67EprthcX+zii9s=; b=bba98xSXi77/5KOF0pD/K8fvmE3gsCa+LHNZpuiq8klDJ/IR2RGhQbHYah3grZbTacIoDp zMU1KwswXSFlm/5W6u/gFUiI3Rq7sBhL5twPX7T770KS/dQ1+FjT2a6eduS6shMaV3oJ0E drTgkXGWrZdL7ufu5INUeU1ClUCzoWw= From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 09/15] microblaze: Avoid clobbering register parameters in syscall References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-9-adhemerval.zanella@linaro.org> Date: Tue, 11 Feb 2020 12:21:32 +0100 In-Reply-To: <20200210192038.23588-9-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 10 Feb 2020 16:20:32 -0300") Message-ID: <87v9odnzcz.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: > The microblaze INTERNAL_SYSCALL macro might clobber the register > parameter if the argument itself might clobber any register (a function > call for instance). > > This patch fixes it by using temporary variables for the expressions > between the register assignments (as indicated by GCC documentation, > 6.47.5.2 Specifying Registers for Local Variables). > > It is similar to the fix done for MIPS (BZ#25523). (bug 25523) for the bug reference, so that it will be recognized by the commit hook. Rest looks good. Thanks, Florian