From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 03AA51F45E for ; Tue, 11 Feb 2020 12:36:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=xEMY+ni5I/dCkT0uBQrkPUUuMK1oMyLEWAxfDywD+iH 3Gf9W3BqspEKB+1Zat8GdXMiv7mnRD/r0y2diR5WrmFBF001V/XDpf+lBuF4XeiW vWAsLhQ/hLnUHsoga9i42U4KHIjUHmetTA06PXzQqRp35SNp/m1k+LMCx8bG/yrk = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=Hsk3i6QA/XDXhzSXtVHD5C9m3c0=; b=aHWORsP+hJNOePyqd 7DimNcr1fjRdKEAzNB4rF4RT3IIHXesTZrIVBZe3RPF8ZCCdUWKNUrs0sW+CMY9j 8VZl2rrT+z09M1dqfuXf80cY/JKvsergbylvED86SnpdzYCziQBnnGYoJVBENt65 8tT21Fo29RLyFCZAKveQNz3i9k= Received: (qmail 102578 invoked by alias); 11 Feb 2020 12:36:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 102566 invoked by uid 89); 11 Feb 2020 12:36:46 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581424604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cXAeutQoP4KMvqmnkmDkV00Dk+1RC98UX3srZpp3ujU=; b=TloE/h8OmcFYmXnzAh4WaYcX7ND+m51WpJ6/6pbxwfhfyQKqUtCdQCqGlI/ZUYagqA7HRF 1Cm86qOVOpepgl8pfRwWncKTFiyoFffrwzGh5UrK4qwhSF6btZx0rN4YOI213rl/lCBHe8 7KEV8P8kMyegGSvgMDZ29gIRYv8eF8g= From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-15-adhemerval.zanella@linaro.org> Date: Tue, 11 Feb 2020 13:36:39 +0100 In-Reply-To: <20200210192038.23588-15-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 10 Feb 2020 16:20:38 -0300") Message-ID: <87v9odmhbc.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: > diff --git a/sysdeps/unix/sysv/linux/personality.c b/sysdeps/unix/sysv/li= nux/personality.c > index 970bd7becd..d0c597b6a0 100644 > --- a/sysdeps/unix/sysv/linux/personality.c > +++ b/sysdeps/unix/sysv/linux/personality.c > @@ -35,15 +35,14 @@ __personality (unsigned long persona) > persona =3D (unsigned int) persona; > #endif > =20 > - INTERNAL_SYSCALL_DECL (err); > - long ret =3D INTERNAL_SYSCALL (personality, err, 1, persona); > + long ret =3D INTERNAL_SYSCALL_CALL (personality, persona); > =20 > /* Starting with kernel commit v2.6.29-6609-g11d06b2, the personality = syscall > never fails. However, 32-bit kernels might flag valid values as er= rors, so > we need to reverse the error setting. We can't use the raw result = as some > arches split the return/error values. */ > - if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (ret, err))) > - ret =3D -INTERNAL_SYSCALL_ERRNO (ret, err); > + if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (ret))) > + ret =3D -INTERNAL_SYSCALL_ERRNO (ret); > return ret; > } > weak_alias (__personality, personality) The comment is now outdated, I think, and the code should be simplified in this change (maybe as a separate commit). You could also use long int instead of long here. Thanks, Florian