From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 21FB71F619 for ; Thu, 27 Feb 2020 10:34:39 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=YYLDM Aa75xq2nG3J0B+mZYYCULy2ONUe/SjxI/sKTf1HnXTC7dyEHpI7x/LP7mjkW3UZc 4AiRm62bXtFeKSfpLCxYcOgeBdaSyGNoHD7HH9MpqD0ygZiAT/jbhLPGFjVgb9i1 V2hKllzOEOuPAoai3PQpqEflYE7/hUTT3ErqS4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=czWjbMHJ+iJ j87uxI2u2WjUk/uo=; b=YYJd5Usoola5I7g/RVbfUHFEqClLmf01nXPD/l0sCvn dUGC2KuQysNon+BvJTbatsQjxdYFFHO9r6oswd/FxKXknlSSpbHd4voKjqxlug7q 4LHZZ9DePykkTDmDIAXuojPzoE39aBi1CAF936p+tTJUqO4EBWyj37eqSIvrzgVw = Received: (qmail 26752 invoked by alias); 27 Feb 2020 10:34:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 10646 invoked by uid 89); 27 Feb 2020 10:32:58 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582799576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2pWyPH2/Ft3GL3DYnjQSn7n1AXiKP/1omIif/rcF0CY=; b=dyJLwTJMpReLTsuIcLlxTlOTncwbZOcBxVALMv7hbobU+oD/zXhbG80Y+v0PzqOiPHi+09 Wy5hQN8nWXvunEwgkmxvkiTxDIKuSPRcgN0uV+hH6/b2ZksseVagXy4/R3cuqbsPU0Jdo6 BTHgr7JBkUS+VyF/RHLHuT9Q/JJWxnc= From: Florian Weimer To: Szabolcs Nagy Cc: Mathieu Desnoyers , Chris Kennelly , nd@arm.com, "Joel Fernandes\, Google" , Paul Turner , Carlos O'Donell , libc-alpha , linux-kernel , Peter Zijlstra , paulmck , Boqun Feng , Brian Geffon Subject: Re: Rseq registration: Google tcmalloc vs glibc References: <1503467992.2999.1582234410317.JavaMail.zimbra@efficios.com> <20200221154923.GC194360@google.com> <1683022606.3452.1582301632640.JavaMail.zimbra@efficios.com> <1089333712.8657.1582736509318.JavaMail.zimbra@efficios.com> <982202794.8791.1582743392060.JavaMail.zimbra@efficios.com> Date: Thu, 27 Feb 2020 11:32:45 +0100 In-Reply-To: (Szabolcs Nagy's message of "Thu, 27 Feb 2020 10:18:32 +0000") Message-ID: <87v9nsz5f6.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Szabolcs Nagy: > On 26/02/2020 18:56, Mathieu Desnoyers wrote: >> ----- On Feb 26, 2020, at 12:27 PM, Chris Kennelly ckennelly@google.com wrote: >>> I agree that this could potentially violate inviarants, but >>> InitFastPerCpu is not intended to be called by the application. >> >> OK, explicitly documenting this would be a good thing. In my own projects, >> I prefix those symbols with double-underscores (__) to indicate that those >> are not meant to be called by other means than the static inlines in the API. > > use a different convention for that, __ prefix is always > reserved for the implementation for arbitrary use. tcmalloc is *not* the implementation in that sense. It must not use the __ prefix for its identifiers. Thanks, Florian