From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 196A11F8C6 for ; Thu, 26 Aug 2021 15:11:53 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 013373858034 for ; Thu, 26 Aug 2021 15:11:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 013373858034 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629990712; bh=Hc4AlE4+xP/CJ4EFat/DdjY+5ut4S6pFaXRD5EFtHiU=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FRuWYU/9AFb4Po07sykHj01t4WPj0Wp//qamYitW3zmoKKhnhp7e7GEe3R9oZ2uQS Gm8j4T2HYzLmZnOknjr7soLH7JrqGRFWKzPL2JA+egU3/QqTUQwc1y7oEcQUKJzexB 32Pc1kU/1aOnMVoZ9s14OoxKxgpGqhMNHVzpXc8U= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B15D33858402 for ; Thu, 26 Aug 2021 15:11:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B15D33858402 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-RJxrwf5fPt6y33QYoF4Ofw-1; Thu, 26 Aug 2021 11:11:31 -0400 X-MC-Unique: RJxrwf5fPt6y33QYoF4Ofw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A5C71008064 for ; Thu, 26 Aug 2021 15:11:30 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B3BF2B3DE; Thu, 26 Aug 2021 15:11:27 +0000 (UTC) To: Carlos O'Donell Subject: Re: [PATCH v8 1/2] Add 'codepoint_collation' support for LC_COLLATE. References: <20210825133437.2529307-1-carlos@redhat.com> <20210825133437.2529307-2-carlos@redhat.com> Date: Thu, 26 Aug 2021 17:11:25 +0200 In-Reply-To: <20210825133437.2529307-2-carlos@redhat.com> (Carlos O'Donell's message of "Wed, 25 Aug 2021 09:34:36 -0400") Message-ID: <87v93s44wy.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Carlos O'Donell: > @@ -2123,6 +2136,17 @@ collate_output (struct localedef_t *locale, const struct charmap_t *charmap, > /* The words have to be handled specially. */ > if (idx == _NL_ITEM_INDEX (_NL_COLLATE_SYMB_HASH_SIZEMB)) > add_locale_uint32 (&file, 0); > + else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_CODESET) > + && collate != NULL) > + /* A valid LC_COLLATE must have a code set name. */ > + add_locale_string (&file, charmap->code_set_name); > + else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_COLLSEQMB) > + && collate != NULL) > + add_locale_raw_data (&file, collseqmb, sizeof (collseqmb)); > + else if (idx == _NL_ITEM_INDEX (_NL_COLLATE_COLLSEQWC) > + && collate != NULL) > + add_locale_uint32_array (&file, collseqwc, > + array_length (collseqwc)); > else > add_locale_empty (&file); > } This version looks okay to me. Reviewed-by: Florian Weimer Thanks, Florian