From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8BDC01F8C6 for ; Fri, 10 Sep 2021 11:35:02 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A7DA3858C39 for ; Fri, 10 Sep 2021 11:35:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A7DA3858C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631273701; bh=ml25Yq4E335jzUlF3ZMUm27LIBZDtUWsHpURGKFXEm8=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sH1T6a1XMU4GhY281AVGEhZQtaq/2nXWGTMA7aB+lJZYZQlLs327fYyrY1e64KQjt kH7WetfZn/5wYleqd+k7pQAVeTc7ol6eZLIaSa0Bko9ccvB7TL/xvLhPef6/zRgPDk xMAPsXty89uJWguODksy6eZSOJwVTtACm/6+DjPE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id E361C3858C39 for ; Fri, 10 Sep 2021 11:34:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E361C3858C39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-Eu67iIFTO-GV78ewf_ax1g-1; Fri, 10 Sep 2021 07:34:39 -0400 X-MC-Unique: Eu67iIFTO-GV78ewf_ax1g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 911AABBEE7; Fri, 10 Sep 2021 11:34:38 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.195.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 859E35C1D0; Fri, 10 Sep 2021 11:34:37 +0000 (UTC) To: Aurelien Jarno Subject: Re: [PATCH] posix: Fix attribute access mode on getcwd with GNU extension [BZ #27476] References: <20210908225250.3912555-1-aurelien@aurel32.net> Date: Fri, 10 Sep 2021 13:34:35 +0200 In-Reply-To: <20210908225250.3912555-1-aurelien@aurel32.net> (Aurelien Jarno's message of "Thu, 9 Sep 2021 00:52:50 +0200") Message-ID: <87v938irzo.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Aurelien Jarno: > There is a GNU extension that allows to call getcwd(NULL, >0). It is > described in the documentation, but also directly in the unistd.h > header, just above the declaration. > > Therefore, do not define the attribute access mode when __USE_GNU is in > used. I think we should drop the attribute unconditionally. Thanks, Florian