From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-109515-e=80x24.org@sourceware.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham
	autolearn_force=no version=3.4.2
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id AE2881F45E
	for <e@80x24.org>; Tue, 11 Feb 2020 19:45:58 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:references:date:in-reply-to
	:message-id:mime-version:content-type; q=dns; s=default; b=qAac9
	KODigSzEGOmSEIbUH+cqYj9z9+ZHz5k/YoTPojzxS/bUbXNQgWFE7izMRyBFau81
	+N8VBpyFW5JO7+GYiJxGffSNz57friTSCWwao8IdGfXYqS/nokR++tKZAgUsbrsG
	Z5IfM4mZpU3QVNcWRB7V/kKbsvU0I6QD6NVtA4=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:references:date:in-reply-to
	:message-id:mime-version:content-type; s=default; bh=tEVvUdQPNVV
	eFbWxYYJJlEGvdJI=; b=UN6b6SKwEVxPSCdkzvmfkcNJv/DGEUqH2Hnxoawrivt
	vzaVIvdeXVNB0pdaWPHiVhBtHL3OQtS+PkIqB4rxydKtrrcnxBsqygSaLYEhqWJV
	tFTJYYILgahUHqv1O4kYkXc5BiMgVx39hMov869nj6TUnKtUB8vpJCqRqCM10A2Q
	=
Received: (qmail 18583 invoked by alias); 11 Feb 2020 19:45:41 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-e=80x24.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 18391 invoked by uid 89); 11 Feb 2020 19:45:24 -0000
Authentication-Results: sourceware.org; auth=none
X-HELO: albireo.enyo.de
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 01/15] powerpc: Consolidate Linux syscall definition
References: <20200210192038.23588-1-adhemerval.zanella@linaro.org>
Date: Tue, 11 Feb 2020 20:43:40 +0100
In-Reply-To: <20200210192038.23588-1-adhemerval.zanella@linaro.org>
	(Adhemerval Zanella's message of "Mon, 10 Feb 2020 16:20:24 -0300")
Message-ID: <87tv3wnc43.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain

* Adhemerval Zanella:

> +/* Define __set_errno() for INLINE_SYSCALL macro below.  */
> +#ifndef __ASSEMBLER__
> +#include <errno.h>
> +#endif

Missing indentation (but the existing files are not consistent about
that).

> +/* Pointer mangling support.  */
> +#if defined(__PPC64__) || defined(__powerpc64__)
> +# define LOAD  ld
> +# define TPREG r13
> +#else
> +# define LOAD  lwz
> +# define TPREG r2
> +#endif

Can you restrict those to #ifdef __ASSEMBLER__?  <sysdep.h> is a
fairly widely included header, and this has the potential of breaking
future changes that compile on other architectures.

Rest looks okay to me, but maybe a POWER maintainer wants to have a
look as well.