From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 462651F4B4 for ; Thu, 22 Oct 2020 09:16:35 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 86222386F414; Thu, 22 Oct 2020 09:16:34 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 01B6C3844047 for ; Thu, 22 Oct 2020 09:16:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 01B6C3844047 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CH1vM0PWCz1qsk3; Thu, 22 Oct 2020 11:16:31 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CH1vM062Kz1qvgS; Thu, 22 Oct 2020 11:16:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id hGjF_Yzve4ho; Thu, 22 Oct 2020 11:16:30 +0200 (CEST) X-Auth-Info: JBhq5uNKRIYTgrL0yEkHHmhFHz4uwMTMyvC2/D+W7QBUCxSu9VOT0niGx39+npps Received: from igel.home (ppp-46-244-171-124.dynamic.mnet-online.de [46.244.171.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 22 Oct 2020 11:16:30 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 7D8AA2C109C; Thu, 22 Oct 2020 11:16:29 +0200 (CEST) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 2/5] login: Move gnu utmpx to default implementaion References: <20200729205117.2925113-1-adhemerval.zanella@linaro.org> <20200729205117.2925113-2-adhemerval.zanella@linaro.org> X-Yow: On the other hand, life can be an endless parade of TRANSSEXUAL QUILTING BEES aboard a cruise ship to DISNEYWORLD if only we let it!! Date: Thu, 22 Oct 2020 11:16:29 +0200 In-Reply-To: <20200729205117.2925113-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 29 Jul 2020 17:51:14 -0300") Message-ID: <87tuum7h8y.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Jul 29 2020, Adhemerval Zanella via Libc-alpha wrote: > /* Copy the information in UTMPX to UTMP. */ > void > -getutmp (const struct utmpx *utmpx, struct utmp *utmp) > +__getutmp (const struct utmpx *utmpx, struct utmp *utmp) > { > + memset (utmp, 0, sizeof (struct utmpx)); I think it is better to use sizeof (struct utmp), even if we already proved that it's the same. But then, what prevents us from using memcpy directly? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."