unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/7] linux: Consolidate Linux setsockopt implementation
Date: Mon, 05 Jul 2021 20:59:06 +0200	[thread overview]
Message-ID: <87tul8k2o5.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210705183027.3804093-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 5 Jul 2021 15:30:22 -0300")

* Adhemerval Zanella via Libc-alpha:

> This patch consolidates the setsockopt implementation on
> sysdeps/unix/sysv/linux/getsockopt.c.  The changes are:
>
>   1. Remove it from auto-generation syscalls.list on all architectures.
>
>   2. Add __ASSUME_SETSOCKOPT_SYSCALL as default and undef if for
>      specific kernel versions on some architectures.
>
> This also fix a potential issue where 32-bit time_t ABI should use the
> linux setsockopt which overrides the underlying SO_* constants used for
> socket timestamping for _TIME_BITS=64.

Looks okay to me as well.

Thanks,
Florian


  reply	other threads:[~2021-07-05 18:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 18:30 [PATCH 0/7] Linux 64-bit time_t socket fixes Adhemerval Zanella via Libc-alpha
2021-07-05 18:30 ` [PATCH 1/7] linux: Consolidate Linux getsockopt implementation Adhemerval Zanella via Libc-alpha
2021-07-05 18:58   ` Florian Weimer via Libc-alpha
2021-07-05 18:30 ` [PATCH 2/7] linux: Consolidate Linux setsockopt implementation Adhemerval Zanella via Libc-alpha
2021-07-05 18:59   ` Florian Weimer via Libc-alpha [this message]
2021-07-05 18:30 ` [PATCH 3/7] linux: Use the expected size for SO_TIMESTAMP{NS} convertion Adhemerval Zanella via Libc-alpha
2021-07-05 19:00   ` Florian Weimer via Libc-alpha
2021-07-06 13:06     ` Adhemerval Zanella via Libc-alpha
2021-07-05 18:30 ` [PATCH 4/7] linux: Fix setsockopt fallback Adhemerval Zanella via Libc-alpha
2021-07-05 19:07   ` Florian Weimer via Libc-alpha
2021-07-06 13:07     ` Adhemerval Zanella via Libc-alpha
2021-07-06 14:08       ` Florian Weimer via Libc-alpha
2021-07-05 18:30 ` [PATCH 5/7] support: Add support_socket_time64_timestamp Adhemerval Zanella via Libc-alpha
2021-07-05 18:46   ` Florian Weimer via Libc-alpha
2021-07-05 18:51     ` Adhemerval Zanella via Libc-alpha
2021-07-05 18:30 ` [PATCH 6/7] socket: Add recvmsg timestamp test Adhemerval Zanella via Libc-alpha
2021-07-05 19:32   ` Florian Weimer via Libc-alpha
2021-07-05 19:51     ` Adhemerval Zanella via Libc-alpha
2021-07-05 20:02       ` Florian Weimer via Libc-alpha
2021-07-05 20:35         ` Adhemerval Zanella via Libc-alpha
2021-07-06  9:29           ` Florian Weimer via Libc-alpha
2021-07-06 12:55             ` Adhemerval Zanella via Libc-alpha
2021-07-06 14:50               ` Florian Weimer via Libc-alpha
2021-07-05 18:30 ` [PATCH 7/7] socket: Add recvmmsg " Adhemerval Zanella via Libc-alpha
2021-07-05 19:12   ` Florian Weimer via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tul8k2o5.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).