From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AB99C1F8C6 for ; Mon, 13 Sep 2021 11:05:24 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D12B63857C7F for ; Mon, 13 Sep 2021 11:05:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D12B63857C7F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631531123; bh=jT+oE59A/YtHjzh0FahSPKCNhJtVy1tO04KsUnii2vs=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dsIV7RW1pPVECbdiaHI/Phs1GkrGp3d9ed0sF9xpMAP+Fc9LFLvgsbLN8Iy7y2TKI u+w+ZB/VYPiCRZLWaZ4usyda9in82J3dp8v4DQO2E0sCyWEcGtFzYWleCnbrFppDkk zw2qKWsso7wKYNkSbXZoP6bCafUpIxU9ZbTzQlCE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 5BF30385841A for ; Mon, 13 Sep 2021 11:05:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BF30385841A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-6jK8ZTT4M2a7CbHSHJSeNg-1; Mon, 13 Sep 2021 07:05:03 -0400 X-MC-Unique: 6jK8ZTT4M2a7CbHSHJSeNg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C2D3362FC; Mon, 13 Sep 2021 11:05:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.195.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB8931025F72; Mon, 13 Sep 2021 11:05:00 +0000 (UTC) To: Adhemerval Zanella Subject: Re: [PATCH v2 2/3] linux: Simplify get_nprocs References: <20210907122259.79800-1-adhemerval.zanella@linaro.org> <20210907122259.79800-3-adhemerval.zanella@linaro.org> Date: Mon, 13 Sep 2021 13:04:59 +0200 In-Reply-To: <20210907122259.79800-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 7 Sep 2021 09:22:58 -0300") Message-ID: <87tuiod9d0.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: Nicolas Saenz Julienne , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > diff --git a/posix/tst-sched_getaffinity.c b/posix/tst-sched_getaffinity.c > new file mode 100644 > index 0000000000..6d1fdcb05f > --- /dev/null > +++ b/posix/tst-sched_getaffinity.c Maybe add a comment that this test may fail on large systems with more than 2048 possible CPUs? > + . */ Should be https://. > +static int > +do_test (void) > +{ > + /* The values are larger than the default cpu_set_t. */ > + const int bufsize[] = { 1<<11, 1<<12, 1<<13, 1<<14, 1<<15, 1<<16, 1<<17 }; > + int cpucount[array_length(bufsize)]; Missing space after array_length. > + > + for (int i = 0; i < array_length (bufsize); i++) > + { > + cpu_set_t *cpuset = CPU_ALLOC (bufsize[i]); > + TEST_VERIFY (cpuset != NULL); > + size_t size = CPU_ALLOC_SIZE (bufsize[i]); > + TEST_COMPARE (sched_getaffinity (0, size, cpuset), 0); > + cpucount[i] = CPU_COUNT_S (size, cpuset); > + CPU_FREE (cpuset); > + } > + > + for (int i = 0; i < array_length (cpucount) - 1; i++) > + for (int j = 1; j < array_length (cpucount); j++) > + TEST_COMPARE (cpucount[i], cpucount[j]); I think the inner loop is redudant, you can use: for (int i = 0; i < array_length (cpucount) - 1; i++) TEST_COMPARE (cpucount[i], cpucount[i + 1]); Rest looks okay. Reviewed-by: Florian Weimer Thanks, Florian