From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 615AA1F4B4 for ; Tue, 13 Oct 2020 09:29:41 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 658C33850411; Tue, 13 Oct 2020 09:29:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 658C33850411 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602581380; bh=vIFBVCV4Wjl5GSOlbWaeNlkASl6GIJegOLwa7gFcdW8=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=kuQsc2deTzt7gVTbqKyE4n7MvnY7+wIl01dmIQP3DdF/AhCkBdLT3Uz7kf2OSiJI8 8n7jpZ3FucmAit76Cxa3Z9mQFNJgbmL0gAJQ2rHHy4Cyviki3nybA3yyiBuk3tPC/+ AoyRWlrhULt6IfOWd59qcA+DP7epoC5k7og1ZHNg= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C7A5F3857003 for ; Tue, 13 Oct 2020 09:29:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C7A5F3857003 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-c6jKF0LYNXmEijWvwEDvPg-1; Tue, 13 Oct 2020 05:29:36 -0400 X-MC-Unique: c6jKF0LYNXmEijWvwEDvPg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E93A01019645; Tue, 13 Oct 2020 09:29:35 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-237.ams2.redhat.com [10.36.114.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36A357665A; Tue, 13 Oct 2020 09:29:35 +0000 (UTC) To: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH v2 2/3] x86_64: Add glibc-hwcaps support References: <54bcc4776d50207d54ca1eae32bdffaa6ffe3c01.1602515612.git.fweimer@redhat.com> Date: Tue, 13 Oct 2020 11:29:33 +0200 In-Reply-To: (H. J. Lu via Libc-alpha's message of "Mon, 12 Oct 2020 11:11:11 -0700") Message-ID: <87sgaiwk1u.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * H. J. Lu via Libc-alpha: >> diff --git a/sysdeps/x86_64/dl-hwcaps-subdirs.c b/sysdeps/x86_64/dl-hwcaps-subdirs.c >> new file mode 100644 >> index 0000000000..c4d8b3a02a >> --- /dev/null >> +++ b/sysdeps/x86_64/dl-hwcaps-subdirs.c >> +#include >> +#include >> > > Please use . How does this work? There is no wrapper header for it, so its functionality is not really available within ld.so. >> diff --git a/sysdeps/x86_64/tst-glibc-hwcaps.c b/sysdeps/x86_64/tst-glibc-hwcaps.c >> new file mode 100644 >> index 0000000000..b46e7cb236 >> --- /dev/null >> +++ b/sysdeps/x86_64/tst-glibc-hwcaps.c >> +#include >> +#include >> +#include > > Please include . I don't want to test the implementation against itself. I'd rather use the GCC functionality and if necessary, add the additional feature checks by open-coding the CPU analysis. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill