From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 315FF1F4B4 for ; Tue, 13 Oct 2020 15:34:15 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0807C3894439; Tue, 13 Oct 2020 15:34:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0807C3894439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602603254; bh=dklzjjXYE0tCkLpKQ6/eXcMDwgArvazuAj5PIoay6kk=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F6MGaj+Xsb7Bkpyk4vb9U43hgGvPXOM4YgQ2Dxovdx1c9SuLTRQGP4o9d5xK/yUcZ DvEnDQqYN0kPfPT5nvNYkQAb2aFBEDchiQnWBSEInozRlrMh1UdLrtMS7BBnPYk/nh TW3O/KgOV2ETnz5to9uvuMWHXnsIrV9w9RC+NyQo= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B19E83861817 for ; Tue, 13 Oct 2020 15:34:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B19E83861817 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-GCOnH__MPtCx1eccu6qu_A-1; Tue, 13 Oct 2020 11:34:07 -0400 X-MC-Unique: GCOnH__MPtCx1eccu6qu_A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D2E6835B91; Tue, 13 Oct 2020 15:34:06 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-237.ams2.redhat.com [10.36.114.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3999D6198C; Tue, 13 Oct 2020 15:34:05 +0000 (UTC) To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v2 2/9] linux: Simplify opendir buffer allocation References: <20201002170620.1611673-1-adhemerval.zanella@linaro.org> <20201002170620.1611673-3-adhemerval.zanella@linaro.org> Date: Tue, 13 Oct 2020 17:34:03 +0200 In-Reply-To: <20201002170620.1611673-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 2 Oct 2020 14:06:13 -0300") Message-ID: <87sgairvh0.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: James Clarke , John Paul Adrian Glaubitz Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella via Libc-alpha: > The fallback allocation is removed, so the possible size constraint > should be analyzed just once; __alloc_dir assumes that 'statp' > argument is non-null, and the max_buffer_size move to close its > used. > > Checked on x86_64-linux-gnu and i686-linux-gnu. Looks okay to me. Thanks. Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill