From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D3C8A1F8C6 for ; Mon, 13 Sep 2021 14:42:32 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0E033857C51 for ; Mon, 13 Sep 2021 14:42:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0E033857C51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631544152; bh=so0Jns3Ls2g7jgnNVdSmYQyZf6H3z/48Btodt/EMHZY=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TwBV82MUXFi1Zwe5hL57optE25ScWpNdCTe0Ox8W0uNn7qigVzne8agcciX/z3dvz vxJ//aH3zc1+CCSKNgERIQve7XWAnIRf8imZ5JNKG86h0OdR4sMKcZcLXBebEyo6vM UlcBFUeR8KqX3HwAB1ysE9WWlXd0FCuF/N9eQbtg= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id E2EB83857432 for ; Mon, 13 Sep 2021 14:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E2EB83857432 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-fFsMa9DDOU28mdGMGrvxOA-1; Mon, 13 Sep 2021 10:40:14 -0400 X-MC-Unique: fFsMa9DDOU28mdGMGrvxOA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 220D6101F7A1; Mon, 13 Sep 2021 14:40:13 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.195.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59AB36D983; Mon, 13 Sep 2021 14:40:11 +0000 (UTC) To: "H.J. Lu" Subject: Re: [PATCH v9 1/1] Extend struct r_debug to support multiple namespaces [BZ #15971] References: <20210910201219.156682-1-hjl.tools@gmail.com> <20210910201219.156682-2-hjl.tools@gmail.com> Date: Mon, 13 Sep 2021 16:40:09 +0200 In-Reply-To: <20210910201219.156682-2-hjl.tools@gmail.com> (H. J. Lu's message of "Fri, 10 Sep 2021 13:12:19 -0700") Message-ID: <87sfy8bkty.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: gdb@sourceware.org, libc-alpha@sourceware.org, libc-coord@lists.openwall.com Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * H. J. Lu: > + /* Add the new namespace to the linked list. After a namespace > + is initialized, r_brk becomes non-zero. A namespace becomes > + empty (r_map == NULL) when it is unused. But it is never > + removed from the linked list. */ > + r->r_next = _r_debug_extended.r_next; > + atomic_store_release (&_r_debug_extended.r_next, r); I think the addition should be at the end of the list, and the list update (with release MO) should come last. That should help with reading the list concurrently. Rest looks okay to me. Thanks, Florian