From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 0/8] x86-64: Properly handle the length parameter [BZ# 24097]
Date: Fri, 18 Jan 2019 20:56:35 +0100 [thread overview]
Message-ID: <87r2d9loy4.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOq0wYwkXB_po_3CqMu7T=vJxtxGkXsxUuq-L5mghEPQCw@mail.gmail.com> (H. J. Lu's message of "Fri, 18 Jan 2019 05:14:26 -0800")
* H. J. Lu:
> On Fri, Jan 18, 2019 at 2:50 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> > On x32, the size_t parameter may be passed in the lower 32 bits of a
>> > 64-bit register with the non-zero upper 32 bits. The string/memory
>> > functions written in assembly can only use the lower 32 bits of a
>> > 64-bit register as length or must clear the upper 32 bits before using
>> > the full 64-bit register for length.
>> >
>> > This pach fixes string/memory functions written in assembly for x32.
>> > Tested on x86-64 and x32. On x86-64, libc.so is the same with and
>> > withou the fix.
>>
>> Can this bug result in buffer overflows? Should we obtain a CVE
>
> Yes, definitely.
>
>> identifier?
>>
>
> Yes, please. Can you do that for me?
Done, MITRE gave us CVE-2019-6488. Please reference this in the
ChangeLog and the commit message if you have not done so. Please also
add short NEWS entry in the security section. Thanks.
Florian
next prev parent reply other threads:[~2019-01-18 19:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 16:53 [PATCH 0/8] x86-64: Properly handle the length parameter [BZ# 24097] H.J. Lu
2019-01-17 16:53 ` [PATCH 1/8] x86-64 memchr/wmemchr: " H.J. Lu
2019-01-18 13:25 ` H.J. Lu
2019-01-17 16:53 ` [PATCH 2/8] x86-64 memcmp/wmemcmp: " H.J. Lu
2019-01-17 16:53 ` [PATCH 3/8] x86-64 memcpy: " H.J. Lu
2019-01-17 16:53 ` [PATCH 4/8] x86-64 memrchr: " H.J. Lu
2019-01-17 16:53 ` [PATCH 5/8] x86-64 memset/wmemset: " H.J. Lu
2019-01-17 16:53 ` [PATCH 6/8] x86-64 strncmp family: " H.J. Lu
2019-01-17 16:53 ` [PATCH 7/8] x86-64 strncpy: " H.J. Lu
2019-01-17 16:53 ` [PATCH 8/8] x86-64 strnlen/wcsnlen: " H.J. Lu
2019-01-18 10:50 ` [PATCH 0/8] x86-64: " Florian Weimer
2019-01-18 13:14 ` H.J. Lu
2019-01-18 13:31 ` Florian Weimer
2019-01-18 13:32 ` H.J. Lu
2019-01-18 19:56 ` Florian Weimer [this message]
2019-01-18 20:15 ` H.J. Lu
2019-01-18 20:21 ` Florian Weimer
2019-01-18 20:24 ` H.J. Lu
2019-01-18 20:40 ` Florian Weimer
2019-01-18 20:47 ` H.J. Lu
2019-01-19 3:23 ` Rical Jasan
2019-01-19 10:38 ` Florian Weimer
2019-01-19 15:13 ` H.J. Lu
2019-01-20 15:50 ` H.J. Lu
2019-01-18 20:15 ` Florian Weimer
-- strict thread matches above, loose matches on Subject: below --
2019-01-18 20:12 H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2d9loy4.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).