From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Introduce <elf-initfini.h> and ELF_INITFINI for all architectures
Date: Sun, 09 Feb 2020 10:02:11 +0100 [thread overview]
Message-ID: <87r1z4nnfw.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <05bdd37e-add4-eee1-c075-c5aa606951a7@linaro.org> (Adhemerval Zanella's message of "Wed, 5 Feb 2020 13:50:42 -0300")
* Adhemerval Zanella:
>> @@ -40,11 +41,6 @@ call_init (struct link_map *l, int argc, char **argv, char **env)
>> && l->l_type == lt_executable)
>> return;
>>
>> - /* Are there any constructors? */
>> - if (l->l_info[DT_INIT] == NULL
>> - && __builtin_expect (l->l_info[DT_INIT_ARRAY] == NULL, 1))
>> - return;
>> -
>
> Is the idea of removing the early return to always print the debug
> message below?
Yes, I think this message is helpful to show what is going on,
although like so many dynamic linker log messages, its wording could
probably be improved.
I do not think it matters today because every object linked by current
GCC contains an ELF constructor (the _ITM_registerTMCloneTable stuff).
next prev parent reply other threads:[~2020-02-09 9:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 14:23 [PATCH] Introduce <elf-initfini.h> and ELF_INITFINI for all architectures Florian Weimer
2020-02-05 16:50 ` Adhemerval Zanella
2020-02-09 9:02 ` Florian Weimer [this message]
2020-02-18 14:13 ` Florian Weimer
2020-02-20 16:37 ` Andreas Schwab
2020-02-20 16:40 ` Florian Weimer
2020-02-20 16:56 ` Andreas Schwab
2020-02-20 17:11 ` Andreas Schwab
2020-02-20 18:48 ` Florian Weimer
2020-02-20 22:48 ` Jim Wilson
2020-02-21 12:41 ` Florian Weimer
2020-02-21 18:34 ` Florian Weimer
2020-02-21 21:11 ` Jim Wilson
2020-02-21 21:20 ` David Abdurachmanov
2020-02-24 9:13 ` Andreas Schwab
2020-02-24 12:31 ` Florian Weimer
2020-02-24 9:12 ` Andreas Schwab
2020-02-24 10:21 ` Florian Weimer
2020-02-26 19:10 ` ELF_INITFINI for ARC (was Re: [PATCH] Introduce <elf-initfini.h> and ELF_INITFINI for all architectures) Vineet Gupta
2020-02-26 19:27 ` Florian Weimer
2020-02-26 20:02 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1z4nnfw.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).