From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A83101F48A for ; Tue, 11 Feb 2020 12:48:56 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=I3UaG13GwGvY7Cbt4hQNsq1rImlw4q3zEC61XdcQXM7 rO+lPdNYGbC+2kcIOzvqtb6BMvVrd32w8jsWp2ntDSwyDWl/S4ODR+zGxH63xCqy ZLMO+4QLQt1NrhdDnA6+z5kpAqtEEDNGu4d8gJYN1rO6EmHUSe0LMyiSeBZ3hAQk = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=VbBzAVSyr6QXIquoWsDeb4VkNCk=; b=BvH508SaoYXGB83Jz Ebk6N7r22mc2zbSmKYuYlKqLlmmIhKVlhRtsKvmhTVIbEQQrR8kMpqzhMhHk8yT9 boMwcYnj0tD5C7n11QTWxknuOVIeX3l2A+nDDaxvMLDPG5l8ItOm3xz42TKwX9V0 Aaud4DYqa7Ere3noccmveNektE= Received: (qmail 16223 invoked by alias); 11 Feb 2020 12:48:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11285 invoked by uid 89); 11 Feb 2020 12:48:24 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581425296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yJUI+sHS0nPa/WBZc6er3ejnFPVIymOAoh7wGoeuiyc=; b=Tic3dlA2UP9sfoRaqxjuDVYmRDA6rq1cxfvBjDVecddUT4uV2CnTo0wXV5czIM6QHgXuV7 rVGmnDNS7ndsW8gpk4K0aazMZ7R3QxPfpJwOVmWRJEiRCDyVaa3sOypjf3QLwE6f3ECuMT lFpu0pxVqrwP4/bMGF6LzxdlWqsprec= From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-15-adhemerval.zanella@linaro.org> Date: Tue, 11 Feb 2020 13:48:09 +0100 In-Reply-To: <20200210192038.23588-15-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 10 Feb 2020 16:20:38 -0300") Message-ID: <87r1z1mgs6.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: > With all Linux ABIs using the expected Linux kABI to indicate > syscalls errors, the INTERNAL_SYSCALL_DECL is an empty declaration > on all ports. > > This patch removes the 'err' argument on INTERNAL_SYSCALL* macro > and remove the INTERNAL_SYSCALL_DECL usage. I see some cases where you modify lines which contain INTERNAL_SYSCALL without changing it to INTERNAL_SYSCALL_CALL. Maybe you can fix those as well? Same for long vs long int. Apart from the other quirks I mentioned, this patch looks okay to me. Thanks, Florian