unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 1/3] support: Add support_process_state_wait
Date: Tue, 18 Feb 2020 18:54:06 +0100	[thread overview]
Message-ID: <87r1yrye69.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <ea7e58e1-230c-2b22-bcb5-02cb1cf19f02@linaro.org> (Adhemerval Zanella's message of "Tue, 18 Feb 2020 14:52:16 -0300")

* Adhemerval Zanella:

>> I think it would be clearer to use ferror to check for errors.
>
> Maybe: 
>
>    if (ret == -1 || ferror (stream))
>      ...
>
> ?

I think you might get ret == -1 on EOF, too.

Thanks,
Florian


  reply	other threads:[~2020-02-18 17:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 14:02 [PATCH v2 1/3] support: Add support_process_state_wait Adhemerval Zanella
2020-02-18 14:02 ` [PATCH v2 2/3] posix: Refactor tst-waitid (BZ #14666) Adhemerval Zanella
2020-02-18 17:47   ` Adhemerval Zanella
2020-02-27 16:44     ` Adhemerval Zanella
2020-02-18 14:02 ` [PATCH v2 3/3] posix: Remove posix waitid Adhemerval Zanella
2020-02-18 17:47   ` Adhemerval Zanella
2020-02-27 16:45     ` Adhemerval Zanella
2020-02-18 15:17 ` [PATCH v2 1/3] support: Add support_process_state_wait Florian Weimer
2020-02-18 17:52   ` Adhemerval Zanella
2020-02-18 17:54     ` Florian Weimer [this message]
2020-02-18 18:01       ` Adhemerval Zanella
2020-02-18 18:07         ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1yrye69.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).