From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 75FB21F61A for ; Tue, 25 Feb 2020 09:28:07 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=GJxdiPTSTpkLiL/V2qNTJcTLS4cL44DBc7Zff9zDrmB JltZ+iGC9aRyz+auUPFZZXjBEHzvP8jTobUEhWx0SwgiMGH2pu4cWQywo1h0keM7 voq4dlxxCXM23r01evW/HE9SuizoXwQNsWTswGK6m9MGQOrCFnwm5KdOkjL/fws8 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=8utppV+pEgEUjyJgkBc8Bz5DaZs=; b=BzwzPDFtNGFiGTrls kI+Q/lViMIl5KBySikmhNBNSsbtwVFYq8J1rZ0ug2hcxkOFXRshrHJzW4YyKzhc/ zpoeX1KcS4jBlIv20NqK0DpHF8hnOaCMfs8tqvNM/yi9lczrM5ZxYKYXwz/pRuZZ Orqa6GAq2idb5UBVxWwC6/1/k8= Received: (qmail 59297 invoked by alias); 25 Feb 2020 09:28:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 59285 invoked by uid 89); 25 Feb 2020 09:28:04 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582622881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AO6SGyEe+YNvpCDly/8OqBAM2ksSyffP+AJ06ZpZaR8=; b=P/h5kVC9gfua472aDq1NdYk9W+/4b4bc5HlF0KmT84loE0dsG5HblxazyywgmC9FvvyRxZ 4YmjmzhSKfQOFw5dmDTXKyFkUEAk+fai16L26XW04HqVJq2/QfezuYEs3ppmODk3EZCKPv I1emxhRrBGWvDjC4BmE3tGBBzVBdlv0= From: Florian Weimer To: Vineet Gupta Cc: libc-alpha@sourceware.org, arnd@arndb.de, linux-snps-arc@lists.infradead.org, alistair23@gmail.com, lukma@denx.de Subject: Re: [PATCH] Force 64-bit time based syscalls for TIMESIZE==64 on 32-bit arches References: <20200224183413.13629-1-vgupta@synopsys.com> Date: Tue, 25 Feb 2020 10:27:54 +0100 In-Reply-To: <20200224183413.13629-1-vgupta@synopsys.com> (Vineet Gupta's message of "Mon, 24 Feb 2020 10:34:13 -0800") Message-ID: <87r1yjhv8l.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Vineet Gupta: > +/* Override syscalls for asm-generic ABIs with 64-bit time. */ > +#if __WORDSIZE =3D=3D 32 && __TIMESIZE =3D=3D 64 > + > +# undef __NR_futex > +# define __NR_futex __NR_futex_time64 > + > +# undef __NR_rt_sigtimedwait > +# define __NR_rt_sigtimedwait __NR_rt_sigtimedwait_time64 I'm not totally unsympathetic to this in principle, but I think if we start messing more with the system call numbers in this way, we should move away from the __NR_ prefixes and use our own constant names. Otherwise, the results could be very confusing, especially if there are exceptions to this exception and we need the original system call number after all. Thanks, Florian