From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 06/13] string: Implement strerror in terms of strerror_l
Date: Thu, 28 May 2020 13:41:44 +0200 [thread overview]
Message-ID: <87r1v4cmmf.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200519180518.318733-7-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 19 May 2020 15:05:11 -0300")
> diff --git a/string/strerror.c b/string/strerror.c
> index 283ab70f91..35c749016e 100644
> --- a/string/strerror.c
> +++ b/string/strerror.c
> @@ -15,29 +15,11 @@
> License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> -#include <libintl.h>
> -#include <stdio.h>
> #include <string.h>
> -#include <errno.h>
> -
> -/* Return a string describing the errno code in ERRNUM.
> - The storage is good only until the next call to strerror.
> - Writing to the storage causes undefined behavior. */
> -libc_freeres_ptr (static char *buf);
> +#include <locale/localeinfo.h>
>
> char *
> strerror (int errnum)
> {
> - char *ret = __strerror_r (errnum, NULL, 0);
> - int saved_errno;
> -
> - if (__glibc_likely (ret != NULL))
> - return ret;
> - saved_errno = errno;
> - if (buf == NULL)
> - buf = malloc (1024);
> - __set_errno (saved_errno);
> - if (buf == NULL)
> - return _("Unknown error");
> - return __strerror_r (errnum, buf, 1024);
> + return __strerror_l (errnum, __libc_tsd_get (locale_t, LOCALE));
> }
Why is it okay to share the buffer between strerror and strerror_l?
POSIX is a bit unclear about this. Practically speaking, it should be
okay. But perhaps there should be a NEWS entry.
Thanks,
Florian
next prev parent reply other threads:[~2020-05-28 11:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 18:05 [PATCH 00/13] Signal and error list refactoring Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH v2 01/13] signal: Add signum-{generic,arch}.h Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH v3 02/13] signal: Move sys_siglist to a compat symbol Adhemerval Zanella via Libc-alpha
2020-05-28 14:50 ` Florian Weimer via Libc-alpha
2020-05-19 18:05 ` [PATCH v3 03/13] signal: Move sys_errlist " Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 04/13] linux: Fix __NSIG_WORDS and add __NSIG_BYTES Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 05/13] string: Remove old TLS usage on strsignal Adhemerval Zanella via Libc-alpha
2020-05-28 11:38 ` Florian Weimer via Libc-alpha
2020-06-01 18:08 ` Adhemerval Zanella via Libc-alpha
2020-06-01 18:13 ` Florian Weimer
2020-06-01 18:39 ` Adhemerval Zanella via Libc-alpha
2020-06-01 18:43 ` Florian Weimer
2020-05-19 18:05 ` [PATCH 06/13] string: Implement strerror in terms of strerror_l Adhemerval Zanella via Libc-alpha
2020-05-28 11:41 ` Florian Weimer via Libc-alpha [this message]
2020-06-01 18:28 ` Adhemerval Zanella via Libc-alpha
2020-06-03 8:24 ` Florian Weimer via Libc-alpha
2020-06-03 15:13 ` Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 07/13] string: Use tls-internal on strerror_l Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 08/13] string: Simplify strerror_r Adhemerval Zanella via Libc-alpha
2020-05-28 11:56 ` Florian Weimer via Libc-alpha
2020-06-01 18:31 ` Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 09/13] string: Add strsignal test Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 10/13] string: Add strerror, strerror_r, and strerror_l test Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 11/13] string: Add strerror_l on test-strerror-errno Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 12/13] string: Add sigabbrev_np and sigdescr_np Adhemerval Zanella via Libc-alpha
2020-05-19 18:47 ` Joseph Myers
2020-05-28 12:31 ` Florian Weimer via Libc-alpha
2020-06-03 16:39 ` Adhemerval Zanella via Libc-alpha
2020-05-19 18:05 ` [PATCH 13/13] string: Add errname_np and errdesc_np Adhemerval Zanella via Libc-alpha
2020-05-28 12:28 ` Florian Weimer via Libc-alpha
2020-06-01 20:52 ` Adhemerval Zanella via Libc-alpha
2020-06-02 17:13 ` Adhemerval Zanella via Libc-alpha
2020-06-02 17:19 ` Florian Weimer via Libc-alpha
2020-06-02 17:20 ` Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1v4cmmf.fsf@oldenburg2.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).