From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 67FAC1F461 for ; Tue, 25 Jun 2019 13:23:17 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=YGGEf NiZfN3jBdc7C1o9emGdLawOX1v6e5JL1er7Z3AxXI1GwN1m7Ud+s/Uj41JGxEoLv P1Bz/sPgdT8B1gQUM72gn1ObT/LieN/3cPxzEg//4iVR5DiOuCQ5H8knNJJH7Zsg Hw2KYxwVxDWtvw27IBMGnypxt/reBbl70AbJ74= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=+flIDSFEokR v/pzqjUuT00be7CM=; b=WFLaiX+6EbwIUFbQpernfOL6+63NGz9CYPH2HbtIypG hJnOuBiYavQw3H3tghltvOqMRgMZnhisgdlvQAs9Q1DZtZhV7Q1FW9jQ114seTAX U7qA6HYpG03GyxbZKxn+nNn0pnF6vKYjynJAtxL4Zyn6J8NfWQUCYtT84X3Mjc4c = Received: (qmail 64239 invoked by alias); 25 Jun 2019 13:23:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 64230 invoked by uid 89); 25 Jun 2019 13:23:14 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Stefan Liebler Cc: GNU C Library Subject: Re: [PATCH] Fix build warnings in locale/programs/ld-ctype.c References: <45faf360-cad3-7c9b-a914-0823d2724b90@linux.ibm.com> Date: Tue, 25 Jun 2019 15:23:10 +0200 In-Reply-To: <45faf360-cad3-7c9b-a914-0823d2724b90@linux.ibm.com> (Stefan Liebler's message of "Tue, 25 Jun 2019 15:17:17 +0200") Message-ID: <87pnn12401.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Stefan Liebler: > diff --git a/locale/programs/ld-ctype.c b/locale/programs/ld-ctype.c > index e6105928da..cfc9c43fd5 100644 > --- a/locale/programs/ld-ctype.c > +++ b/locale/programs/ld-ctype.c > @@ -1396,7 +1396,8 @@ charclass_symbolic_ellipsis (struct linereader *ldfile, > (int) (now->val.str.lenmb - (cp - last_str)), > from); > > - get_character (now, charmap, repertoire, &seq, &wch); > + if (get_character (now, charmap, repertoire, &seq, &wch)) > + goto invalid_range; Maybe write: if (get_character (now, charmap, repertoire, &seq, &wch) != 0) to match the other function calls? Otherwise, looks good. Thanks, Florian