From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1C7B51F45E for ; Tue, 11 Feb 2020 19:47:08 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=STXLu dwYz4rJ8UQloZyB1iHW3/NDi7JRCnSW3oPGfu9P9hSrxEzYRcXYrzsYu/aeLpHLW FgLIidshy+Hh/3QOY2x7aESyWB1YVJAbRmdtpIVL65dD5Zsjr4Za/FselvEkbhdv ieW1GJNY5bsV7Kq0+iQJ3FWvbcon0Er/zEFBJo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=fAf8sErZkRh 7Z02W7WFlrQ+Q8u4=; b=puRwM/UiwMZ2TQlbz7nJ4DOncQvz5mR5lyPBe5QCKo5 +ky8+zOy9ezw1XY6KBiSl2PAwrv9PzH1zpXSYoNdpLfB7VKTHYqSl0KXUcgKMnD/ otYI7tSYbSq33Vx8XrRbM99lNR+J1q0yHWRwz3CKMs/SWT26GifNmgdxYens1jlU = Received: (qmail 20905 invoked by alias); 11 Feb 2020 19:47:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 20895 invoked by uid 89); 11 Feb 2020 19:47:04 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: albireo.enyo.de From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 02/15] powerpc: Use Linux kABI for syscall return References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-2-adhemerval.zanella@linaro.org> Date: Tue, 11 Feb 2020 20:45:38 +0100 In-Reply-To: <20200210192038.23588-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 10 Feb 2020 16:20:25 -0300") Message-ID: <87pneknc0t.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain * Adhemerval Zanella: > It changes the powerpc INTERNAL_VSYSCALL_CALL and INTERNAL_SYSCALL_NCS > to return a negative value instead of returning the CR value on 'err' > macro argument. value on? This part is unclear to me. > The macro INTERNAL_SYSCALL_DECL is no longer required, and the > INTERNAL_SYSCALL_ERROR_P follows the other Linux kABIS. See my other comment about wording here. The patch looks reasonable to me.