From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AC3E41F45E for ; Tue, 11 Feb 2020 21:01:07 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=pb+zzf4SDQ/b0Wj2G9HNgz22vLZ2v9ORH7O1WSYWIxq B7QiDVxAvG3La2iC6YGpHPeBPLks2kObcP6m9doAarf2m3MJ4F+JjrW+0KNS9eb/ y4psOMotlgmXFW651hYdOD/z+bIxU5UxKQPLiNDKWKT1+NO9rje9BLQxXHU99LiY = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=fjz/YXCz42kElPB618Acn9ukXbo=; b=y2YdYehOC28PLdlE7 ARxsoxx29+ErNWoJyCY9NWfJzxWCiHlWXOStzgroERB0iUkdRK3aEXKZJ9o+5c36 Z6m9RWyYSa8OZHdrXyVph2fwo4Z78ChxQ5aZVF8WxrHFLalV07/VT3Yv2VX9pIWb Hyubbb+s0YeDMUVfOyKCnz4S2c= Received: (qmail 128474 invoked by alias); 11 Feb 2020 21:01:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128312 invoked by uid 89); 11 Feb 2020 21:00:48 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581454829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eoKA0XolIq6+22sSxu9mf72cLpopXr0VXje5yvand4A=; b=iDDWtyS1mW/9DvRz02UF2snvN5bb7kjCiPe3RKez26/MebefaULq7aAgpys0cMiOoWtA7e 1uRSp2Rj419bCiYu1fVQ5I1erLgMlBlkaq+bh96R7Fb5YTnGF7GQA1uueCtcyFWcBUguPo LSL3OHS0At8GpUJcJi40HimB5DD8jyc= From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 13/15] linux: Consolidate INLINE_SYSCALL References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-13-adhemerval.zanella@linaro.org> <878sl9nxeb.fsf@oldenburg2.str.redhat.com> <3af4d52d-e39d-6666-f068-498d97bee6ab@linaro.org> Date: Tue, 11 Feb 2020 22:00:23 +0100 In-Reply-To: <3af4d52d-e39d-6666-f068-498d97bee6ab@linaro.org> (Adhemerval Zanella's message of "Tue, 11 Feb 2020 17:53:26 -0300") Message-ID: <87pnekhmag.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: >> The comment seems misleading to me. Does =E2=80=9Cregister saving=E2=80= =9D really >> matter here? I think it's about the -errno behavior. I think the >> comment should explain how this macro is to be used (i.e., it sets errno >> on failure). > > Indeed, it is an artefact from powerpc version. What about: > > /* Define a macro which expands into the inline wrapper code for a system > call. It sets the errno and returns -1 on a failure, or the syscall > return value otherwise. */ Looks good. Thanks, Florian