From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7D3131F8C6 for ; Thu, 8 Jul 2021 14:35:40 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77DD4398B8B0 for ; Thu, 8 Jul 2021 14:35:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77DD4398B8B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625754939; bh=pxKNEWl0zZqYFMTSZsrFwkBUCTWMTxjP8fRnMe6x/UY=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vIf+S5SEcpXOOPJiTxDCqjrC36lVaVbtWKg1c7tJzQ01+8J67aLhy03BBV6BanrGK YI7Vfk3fr9Nfcic2l7iq8Q3w4yFfv5CWM6e17g9iKgIQWuo7PSApZCq9sxhkKS6h1f MJRtL237gu6XsV94VAvmhcrOqaR+1dDJSWGUp0fI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 9C05D398B8B3 for ; Thu, 8 Jul 2021 14:34:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C05D398B8B3 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-QL5ID_GcMi-TZvwMcH_-_A-1; Thu, 08 Jul 2021 10:34:57 -0400 X-MC-Unique: QL5ID_GcMi-TZvwMcH_-_A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 083CB1835AC2; Thu, 8 Jul 2021 14:34:57 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3253160843; Thu, 8 Jul 2021 14:34:56 +0000 (UTC) To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v7 4/4] posix: Add posix_spawn_file_actions_addclosefrom_np References: <20210706145839.1658623-1-adhemerval.zanella@linaro.org> <20210706145839.1658623-5-adhemerval.zanella@linaro.org> Date: Thu, 08 Jul 2021 16:34:54 +0200 In-Reply-To: <20210706145839.1658623-5-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 6 Jul 2021 11:58:39 -0300") Message-ID: <87pmvsswkx.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Some of the new files use: > + . */ That should be: https:// > +/* Called on process re-execution. The arguments are the expected opened > + file descriptors. */ > +_Noreturn static void > +handle_restart (int argc, char *argv[]) > +{ > + size_t nfds = argc > 1 ? argc - 1 : 0; > + struct fd_t > + { > + int fd; > + _Bool found; > + } *fds = xmalloc (sizeof (struct fd_t) * nfds); > + for (int i = 0; i < nfds; i++) > + { > + char *endptr; > + long unsigned int fd = strtoul (argv[i+1], &endptr, 10); > + if (*endptr != '\0' || fd > INT_MAX) > + FAIL_EXIT1 ("readdir: invalid file descriptor value: %s", argv[i]); Should be: FAIL_EXIT1 ("argv[%d]: invalid file descriptor value: %s", i, argv[i]); > @@ -344,7 +346,9 @@ __spawnix (pid_t * pid, const char *file, > /* We need at least a few pages in case the compiler's stack checking is > enabled. In some configs, it is known to use at least 24KiB. We use > 32KiB to be "safe" from anything the compiler might do. Besides, the > - extra pages won't actually be allocated unless they get used. */ > + extra pages won't actually be allocated unless they get used. > + It also acts the slack for spawn_closefrom (including MIPS64 getdents64 > + where it might use about 1k extra stack space. */ Missing closing parenthesis. Rest looks okay to me, thanks. No need to post a new verison, I think. Florian