From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BD0F41F8C6 for ; Thu, 26 Aug 2021 09:39:18 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB85A3858039 for ; Thu, 26 Aug 2021 09:39:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB85A3858039 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629970757; bh=1Bs/TOZ8Ssa0WkE2H6JhR25H0Bsq1uPi6E80JI5Jvlw=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GP5aWUMdU7vfM5CBOMtfMEnLf5p3M/4dpSB64cLZ5I+BPkClmtnje5Wdkuj61EwHx KkRXEUDr8ICoRXN5cQGzKoAUP3dlHfyvW1xU+SFsqCFWyQ+3vdhnaaL5uZnxMLFzMb iWwWc5vuoSbuZKfaZhKb8h4Vz5/GaOykrHi24iLE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C78E73858400 for ; Thu, 26 Aug 2021 09:38:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C78E73858400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-599-6tJh4JesO_yEt3LMet9djA-1; Thu, 26 Aug 2021 05:38:34 -0400 X-MC-Unique: 6tJh4JesO_yEt3LMet9djA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26144193F560; Thu, 26 Aug 2021 09:38:33 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A5A85C22B; Thu, 26 Aug 2021 09:38:31 +0000 (UTC) To: Adhemerval Zanella Subject: Re: [PATCH v2 02/19] nptl: Set cancellation type and state on pthread_exit References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-3-adhemerval.zanella@linaro.org> Date: Thu, 26 Aug 2021 11:38:30 +0200 In-Reply-To: <20210823195047.543237-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 23 Aug 2021 16:50:30 -0300") Message-ID: <87pmu08s15.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > +/* Check if a thread with PTHREAD_CANCEL_ASYNCHRONOUS cancellation on > + blocked read() sets the correct state and type as pthread_exit. */ > +static void * > +tf_cancel_async (void *arg) > +{ > + TEST_VERIFY (pthread_setcanceltype (PTHREAD_CANCEL_ASYNCHRONOUS, NULL) > + == 0); > + > + xpthread_barrier_wait (&b); > + > + pthread_cleanup_push (clh, NULL); This assumes that pthread_cleanup_push is async-cancel-safe. According to this thread: Async cacellation and pthread_cleanup_push this is not always true. Should we build this test with -fno-exceptions? Rest of the patch looks okay to me. Thanks, Florian