From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F3A071F8C6 for ; Fri, 9 Jul 2021 07:47:11 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B4CB3889C10 for ; Fri, 9 Jul 2021 07:47:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9B4CB3889C10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625816830; bh=ziS4srcfyISCEPzne9WaxBJI87VVIt1Dr/+bt503sxo=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hlurBELbBbdNFqoPT+43lUIHsjXW7BGMNt9AQGaKDiR/JMYD05SCEx7Vxl7iJnw2e VROCji1fg+jNhp4P1dbLBJzuwJNCcEr8vvnq1Tk/IACeK4bpUFAhvP5kW7UpJpaVbb wAieewDsS1ww9Ws4Pe5BbG0RTuudslgUnvFDoZzE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F3AB13853837 for ; Fri, 9 Jul 2021 07:46:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3AB13853837 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-ytUeRMRoP4KtBeKBMoyuHg-1; Fri, 09 Jul 2021 03:46:48 -0400 X-MC-Unique: ytUeRMRoP4KtBeKBMoyuHg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E16A5CC621; Fri, 9 Jul 2021 07:46:47 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-103.rdu2.redhat.com [10.10.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAD7F1346F; Fri, 9 Jul 2021 07:46:42 +0000 (UTC) To: Siddhesh Poyarekar Subject: Re: [PATCH v7 2/8] Remove __morecore and __default_morecore References: <20210708174325.3243721-1-siddhesh@sourceware.org> <20210708174325.3243721-3-siddhesh@sourceware.org> <8735soknne.fsf@oldenburg.str.redhat.com> Date: Fri, 09 Jul 2021 09:46:34 +0200 In-Reply-To: (Siddhesh Poyarekar's message of "Fri, 9 Jul 2021 12:32:14 +0530") Message-ID: <87o8bcj5et.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar: > On 7/9/21 11:57 AM, Florian Weimer via Libc-alpha wrote: >> * Siddhesh Poyarekar: >> >>> diff --git a/malloc/hooks.c b/malloc/hooks.c >>> index 45c91d6502..4aa6dadcff 100644 >>> --- a/malloc/hooks.c >>> +++ b/malloc/hooks.c >>> @@ -20,6 +20,8 @@ >>> #if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_34) >>> void weak_variable (*__after_morecore_hook) (void) = NULL; >>> compat_symbol (libc, __after_morecore_hook, __after_morecore_hook, GLIBC_2_0); >>> +void *(*__morecore)(ptrdiff_t); >>> +compat_symbol (libc, __morecore, __morecore, GLIBC_2_0); >>> #endif >> This fails to assemble on ARC (and elsewhere with GCC 9 and >> earlier): >> /tmp/ccEXL6bz.s: Assembler messages: >> /tmp/ccEXL6bz.s: Error: `__morecore@GLIBC_2.32' can't be versioned to common sym >> bol '__morecore' >> You need to add __attribute__ ((morecore)). > > I could do this (I know you mean nocommon there)... > >> I posted a generic fix for this: >> Force building with -fno-common >> >> But until then, every instance needs to be fixed manually. > > ... or I could review your generic fix instead. It seems like a much > better cleanup than having to specify the attribute on everything that > changes. What do you think? Do we want this change for glibc 2.34 at this point? I wasn't sure. Carlos, I guess this is a question for you. Thanks, Florian